Allow moving an insertion marker leftwards, take 2 #252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By recognising an insertion marker as invalid if localConnection has changed, not just if highlightedConnection has changed.
cwillisf
pushed a commit
that referenced
this pull request
Dec 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By recognising an insertion marker as invalid if localConnection has changed, not just if highlightedConnection has changed.
This is sort of a duplicate review of #236, which I merged, then realised I'd hadn't actually tested it and a typo broke the insertion markers. I reverted it, and thought I'd err on the side of caution in sending for review again. Sorry for the mess!