[pull] master from jaegertracing:master #1055
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![pull[bot]](https://avatars.githubusercontent.com/in/12910?s=60&v=4){kind=small}
Ignore Jaeger internal traces in HttpSender. Mark Jaeger client internal requests made by HttpSender with "ot-ignore" property which prevents requests from being instrumented by OpenTracing.Contrib.NetCore package and hides them in UI. Signed-off-by: Philipp Bocharov <bocharovf@gmail.com>
Signed-off-by: Rustam Valiullin <regeldso@users.noreply.github.com>
Signed-off-by: Philipp Bocharov <bocharovf@gmail.com>
Signed-off-by: Roman Marusyk <romamarusyk@gmail.com>
This is just an addition to the issue #105. Seperated the handler.ClientCertificates.AddRange to a function. Some APIs are not implemented in net461, but they are available in netStandard2.0, see: https://stackoverflow.com/a/46577035/10038915 Signed-off-by: Jonas S <j@tkaj.de>
#165) * Replace JAEGER_SAMPLER_MANAGER_HOST_PORT with JAEGER_SAMPLING_ENDPOINT * Readded support for deprecated JAEGER_SAMPLER_MANAGER_HOST_PORT * Adjusted tests for real-world sampler results
Signed-off-by: Yuri Shkuro <ys@uber.com>
* Replaced Jaeger.Thrift.VendoredThrift with official ApacheThrift * Regenerated using Thrift 0.13.0 * Build against .netcore3.1 * Update AppVeyor image Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
* Renamed Jaeger to Jaeger.Core * Renamed Jaeger.Tests to Jaeger.Core.Tests * Added Jaeger meta-package * Extracted Jaeger.Senders.Thrift * Updated documentation * Cleanup of tests * Update appveyor Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
* Added crossdock * Removed ScopeManager * Use Visual Studio 2019 image * Update to .NET Core 3.1 Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
* Do not strip leading zeros from trace IDs * Relax crossdock comparison Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
Fix for #177 by using a cryptographic random number generator instead of current time to seed Random. Signed-off-by: phxnsharp <nsharp@phoenix-int.com>
* Added Jaeger.Senders.Grpc * Added tests for GrpcSender * Use correct MaxPacketSize * Fix documentation * Move Jaeger.Thrift to Jaeger.Communication.Thrift * Add files to solution * Added Jaeger.Communication.Grpc * Remove Grpc.Tools * Protos will be generated from jaeger-idl directly * Fix default sender resolver * Fixed JAEGER_GRPC_ROOT_CERTIFICATE * Added JAEGER_GRPC_CLIENT_CHAIN & JAEGER_GRPC_CLIENT_KEY Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
- WithHttpHandler - WithCertificates - WithUserAgent Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
* Make InMemorySender Asynchronous To demonstrate lost span problem (to be shortly reported). When AppendAsync is actually asynchronous, some spans are lost on Tracer Dispose. This change should have no effect, but causes RemoteReporterTests.TestRemoteReporterFlushesOnClose to fail intermittently. Signed-off-by: phxnsharp <nsharp@phoenix-int.com> * Do not use Task.Factory.StartNew For some reason awaiting the task returned always completes immediately. Signed-off-by: phxnsharp <nsharp@phoenix-int.com> * Add Thread Safety to InMemorySender This didn't help reliability, but I believe it is necessary because different threads may be adding and flushing at the same time. Signed-off-by: phxnsharp <nsharp@phoenix-int.com> * Style cleanup Use slightly better style for _blocker. Also, turns out async in Flush causes other issues, removed for now. Signed-off-by: phxnsharp <nsharp@phoenix-int.com> * Fix Intermittent Test Failure Found several problems that were contributing: - RemoteControlledSampler was using a long lived Wait() call on a thread pool thread, which was consuming Thread Pool threads and causing delays as the thread pool was exausted - RemoteReporter.ProcessQueueLoop does have long lived waits due to the BlockingQueue. Reworked it to work correctly on a LongLived thread without consuming thread pool threads. - Many of the tests were leaving behind the ProcessQueueLoop because the blocker was never released. There is still an intermittent test failure, but that was there before I started changing code. Signed-off-by: phxnsharp <nsharp@phoenix-int.com> Co-authored-by: Benjamin Krämer <falco20019@hotmail.com>
Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
* fixed blocking code in Reporters/RemoteReporter.cs Signed-off-by: Bojan Pantovic <bojan.pantovic@redbox.com> * replace blocking collection with BufferBlock to make everything async Signed-off-by: Bojan Pantovic <bojan.pantovic@redbox.com> * code review changes Signed-off-by: Bojan Pantovic <bojan.pantovic@redbox.com> * code review changes #2 Signed-off-by: Bojan Pantovic <bojan.pantovic@redbox.com> * Fix NuGET related build warnings Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com> Signed-off-by: Bojan Pantovic <bojan.pantovic@redbox.com> Co-authored-by: bojan.pantovic@redbox.com <bojan.pantovic@redbox.com> Co-authored-by: Kraemer, Benjamin <falco20019@hotmail.com>
* Fix gRPC sender's parent span reference Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com> * Fix unit test Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
* Fix typos * Limit maxPacketSize for UdpSender Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
Signed-off-by: albertteoh <albert.teoh@logz.io>
Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
Signed-off-by: Kraemer, Benjamin <falco20019@hotmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )