This repository was archived by the owner on Apr 28, 2022. It is now read-only.
Default SamplingManager set to HttpSamplingManager #157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rustam Valiullin <regeldso@users.noreply.github.com>
regeldso
force-pushed
the
default-sampling-mgr
branch
from
fe1bcd3 to
f81c7cd
Compare
Falco20019
approved these changes
Sep 17, 2019
|
I just published it as v0.3.5 to NuGet. Should be available soon. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default SamplingManager is set to HttpSamplingManager.
https://github.com/jaegertracing/jaeger-client-csharp/tree/master/src/Jaeger/Samplers#remote-controlled-sampler
Which problem is this PR solving?
Even default sampler is RemoteControlledSampler it doesn't have default SamplingManager as it mentioned in documentation that's why this situation produce an exeption during execution.
Short description of the changes
Added default SamplingManager, added one unit test.