This repository was archived by the owner on Apr 28, 2022. It is now read-only.
Ignore Jaeger internal traces in HttpSender (#154) #156
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore Jaeger internal traces in HttpSender. Mark Jaeger client internal requests made by HttpSender with "ot-ignore" property which prevents requests from being instrumented by OpenTracing.Contrib.NetCore package and hides them in UI. Signed-off-by: Philipp Bocharov <bocharovf@gmail.com>
Falco20019
approved these changes
Aug 25, 2019
|
Thanks for fixing it. I currently have only little time. |
|
I just released it as 0.3.4 to NuGET, so that your problem gets fixed quickly. |
pull bot
referenced
this pull request
in scope-demo/jaeger-client-csharp
Aug 25, 2019
Ignore Jaeger internal traces in HttpSender. Mark Jaeger client internal requests made by HttpSender with "ot-ignore" property which prevents requests from being instrumented by OpenTracing.Contrib.NetCore package and hides them in UI. Signed-off-by: Philipp Bocharov <bocharovf@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #154
Short description of the changes
Mark Jaeger client internal requests made by HttpSender with "ot-ignore" property which prevents requests from being instrumented by OpenTracing.Contrib.NetCore package.