Repository navigation
Guard Droid reconcile with live activity - #16
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0ee45c995c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| candidates.push({ created_at: latestEvent.created_at, source: 'd1', parsed: latestEventTime }); | ||
| } | ||
|
|
||
| const roomStatus = await getRunRoomStatus(env, runId); |
There was a problem hiding this comment.
Tolerate run-room status failures during reconcile
When DROID_RUN_ROOMS is configured but the Durable Object lookup/status call fails transiently, this new awaited call makes /v0/runs/:id/reconcile hit the app-level 500 handler before it can fall back to the D1 event history. Run-room writes are already treated as best-effort in createRunEvent, so reconcile should similarly catch/log getRunRoomStatus failures and continue using the D1 candidate; otherwise operators can lose the recovery path for stale running rows exactly when the live room is unavailable.
Useful? React with 👍 / 👎.
Summary
Tests