Disable dns support for buckets when "host_bucket" hostname doesn't have a %(bucket)s item in it. #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ave a %(bucket)s item in it.
|
Proposal to fix the issue: #375 |
|
Merged in PR #430. Closing. |
This was referenced Jan 13, 2015
Closed
|
Hi, nice to see this is already implemented! I finally got to this after checking the readme on the repo, the usage page in http://s3tools.org/usage and manually checking my s3cfg looking for keywords like "path" and "style". I am going to document this (in the readme?) and make a PR as it should be explicitly documented, any ideas/recommendations/documentation preferences welcomed. |
This was referenced Apr 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here is my proposal to support S3 servers that don't support usage of dns hostname for buckets like Ceph:
In the config, currently there is the host_bucket entry that give the bucket "hostname" pattern.
Ex.: host_bucket = "%(bucket)s.s3.amazonaws.com"
With my patch, if you remove the bucket part and only use the base url like that:
Ex.: host_bucket = "s3.amazonaws.com"
Then, dns resolution will be disabled and "path-style" bucket access be used.