Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull request batch2: Batch of my different pull requests #430

Merged
merged 12 commits into from
Dec 3, 2014

Conversation

fviard
Copy link
Contributor

@fviard fviard commented Dec 1, 2014

Following pull requests are grouped in this PR:
#342
#357
#416

This PR is based on "Pull Request batch1" so also include:
#369
#348
#355 ( Bugfix import error)
#385

PanMan and others added 12 commits December 1, 2014 15:31
Prices were out of date, copied from http://aws.amazon.com/s3/pricing/
… error due to dependency on unicodise which was not successfully imported
Some servers (like fakes3), doesn't add quotes in ETags aroung md5 value.
Ex.:
AWS: <LastModified>2014-06-05T09:45:25.000Z</LastModified><ETag>&quot;fc0f71ccc63dda0efc30239b48bdeccd&quot;</ETag><Size>132947133</Size>
FAKES3: <LastModified>2014-06-05T09:58:35.982060ZZ</LastModified><ETag>fc0f71ccc63dda0efc30239b48bdeccd</ETag><Size>132947133</Size>
(Nota: &quot; <=> " )

Bug in the previous code was always striping and first and last characters whatever they were. Such, in a fakes3 case, dest md5 was truncated and so would never match.
In the same time, this patch normalize the behavior to always strip " and ' chars in all the code dealing with etags.
…e a clearer status of the reason of the failure. Some existing exit codes were modified when they were not already in use.
@mdomsch
Copy link
Contributor

mdomsch commented Dec 3, 2014

Both of these batches are merged now, thank you!

On Mon, Dec 1, 2014 at 9:21 AM, Florent Viard notifications@github.com
wrote:

Following pull requests are grouped in this PR:
#342 #342
#357 #357
#416 #416

This PR is based on "Pull Request batch1" so also include:
#369 #369
#348 #348
#355 #355 ( Bugfix import error)

#385 #385

You can merge this Pull Request by running

git pull https://github.com/fviard/s3cmd pull_request_batch2

Or view, comment on, or merge it at:

#430
Commit Summary

  • Changed prices
  • Minor changes in README to fix points 1 and 2 in my comment at
    Changed prices #369.
  • Specify content-type for request with XML body
  • Fixed bug where the error report will not show if there was an
    import error due to dependency on unicodise which was not successfully
    imported
  • Changed the exit code for import errors to not rely on dependency of
    EX_GENERAL being defined when not imported
  • Specify default checks performed on files being synced
  • Cosmetic: removed one empty space in excess of end of run summary.
  • Fix MD5 comparison with s3 compatible servers that are not Amazon S3.
  • Small cleanup of code, using "in" instead of "find" for strings when
    possible.
  • Fix an error in my previous commit:
    b5b61ab. (.find() forgotten to be removed)
  • Improve the exit code of s3cmd in the case of an error from S3 to
    give a clearer status of the reason of the failure. Some existing exit
    codes were modified when they were not already in use.
  • Disable dns support for buckets when "host_bucket" hostname doesn't
    have a %(bucket)s item in it.

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#430.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants