Fix signurl to support path-style bucket access via check_bucket_name_dns_support #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_dns_support When check_bucket_name_dns_support returns False, format the url for path-style bucket access.
|
I'm also being bitten by this issue. @fviard, would you consider merging this PR? |
|
Thank you very much both for the PRs. |
|
Hi @fviard — I'm taking the liberty to bring this up again, 3 months on. Would you consider merging this? |
|
@fviard Could this be merged, please? It's been almost a year since this was submitted. |
|
Merged! Thank you and sorry for the very very long delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When check_bucket_name_dns_support returns False, format the url
for path-style bucket access (related to #416).