std: Stabilize library APIs for 1.5 #29254

alexcrichton · 2015-10-23T16:41:33Z

This commit stabilizes and deprecates library APIs whose FCP has closed in the
last cycle, specifically:

Stabilized APIs:

fs::canonicalize
Path::{metadata, symlink_metadata, canonicalize, read_link, read_dir, exists, is_file, is_dir} - all moved to inherent methods from the PathExt trait.
Formatter::fill
Formatter::width
Formatter::precision
Formatter::sign_plus
Formatter::sign_minus
Formatter::alternate
Formatter::sign_aware_zero_pad
string::ParseError
Utf8Error::valid_up_to
Iterator::{cmp, partial_cmp, eq, ne, lt, le, gt, ge}
<[T]>::split_{first,last}{,_mut}
Condvar::wait_timeout - note that wait_timeout_ms is not yet deprecated
but will be once 1.5 is released.
str::{R,}MatchIndices
str::{r,}match_indices
char::from_u32_unchecked
VecDeque::insert
VecDeque::shrink_to_fit
VecDeque::as_slices
VecDeque::as_mut_slices
VecDeque::swap_remove_front - (renamed from swap_front_remove)
VecDeque::swap_remove_back - (renamed from swap_back_remove)
Vec::resize
str::slice_mut_unchecked
FileTypeExt
FileTypeExt::{is_block_device, is_char_device, is_fifo, is_socket}
BinaryHeap::from - from_vec deprecated in favor of this
BinaryHeap::into_vec - plus a Into impl
BinaryHeap::into_sorted_vec

Deprecated APIs

slice::ref_slice
slice::mut_ref_slice
iter::{range_inclusive, RangeInclusive}
std::dynamic_lib

Closes #27706
Closes #27725
cc #27726 (align not stabilized yet)
Closes #27734
Closes #27737
Closes #27742
Closes #27743
Closes #27772
Closes #27774
Closes #27777
Closes #27781
cc #27788 (a few remaining methods though)
Closes #27790
Closes #27793
Closes #27796
Closes #27810
cc #28147 (not all parts stabilized)

rust-highfive · 2015-10-23T16:41:38Z

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

alexcrichton · 2015-10-23T16:41:47Z

r? @brson

alexcrichton · 2015-10-23T16:42:08Z

cc @rust-lang/libs, would be good to get lots of eyes on this

brson · 2015-10-24T01:41:44Z

@bors r+

bors · 2015-10-24T01:41:46Z

📌 Commit a84f62b has been approved by brson

bors · 2015-10-24T03:12:05Z

⌛ Testing commit a84f62b with merge 604a69f...

bors · 2015-10-24T04:10:19Z

💔 Test failed - auto-mac-64-opt

alexcrichton · 2015-10-24T18:51:09Z

@bors: r=brson 99c0eaab10b753afd0beee9c518cfd2ec1594ddd

bors · 2015-10-25T01:31:37Z

⌛ Testing commit 99c0eaa with merge abf7a85...

bors · 2015-10-25T02:11:59Z

💔 Test failed - auto-mac-64-opt

alexcrichton · 2015-10-25T02:22:29Z

@bors: r=brson 68162b4

bors · 2015-10-25T03:27:11Z

⌛ Testing commit 68162b4 with merge c9c0627...

bors · 2015-10-25T04:10:01Z

💔 Test failed - auto-mac-64-opt

alexcrichton · 2015-10-25T04:32:57Z

@bors: r=brson 8cab27e

bors · 2015-10-25T06:42:55Z

⌛ Testing commit 8cab27e with merge 23b37e4...

bors · 2015-10-25T06:48:20Z

💔 Test failed - auto-linux-64-nopt-t

This commit stabilizes and deprecates library APIs whose FCP has closed in the last cycle, specifically: Stabilized APIs: * `fs::canonicalize` * `Path::{metadata, symlink_metadata, canonicalize, read_link, read_dir, exists, is_file, is_dir}` - all moved to inherent methods from the `PathExt` trait. * `Formatter::fill` * `Formatter::width` * `Formatter::precision` * `Formatter::sign_plus` * `Formatter::sign_minus` * `Formatter::alternate` * `Formatter::sign_aware_zero_pad` * `string::ParseError` * `Utf8Error::valid_up_to` * `Iterator::{cmp, partial_cmp, eq, ne, lt, le, gt, ge}` * `<[T]>::split_{first,last}{,_mut}` * `Condvar::wait_timeout` - note that `wait_timeout_ms` is not yet deprecated but will be once 1.5 is released. * `str::{R,}MatchIndices` * `str::{r,}match_indices` * `char::from_u32_unchecked` * `VecDeque::insert` * `VecDeque::shrink_to_fit` * `VecDeque::as_slices` * `VecDeque::as_mut_slices` * `VecDeque::swap_remove_front` - (renamed from `swap_front_remove`) * `VecDeque::swap_remove_back` - (renamed from `swap_back_remove`) * `Vec::resize` * `str::slice_mut_unchecked` * `FileTypeExt` * `FileTypeExt::{is_block_device, is_char_device, is_fifo, is_socket}` * `BinaryHeap::from` - `from_vec` deprecated in favor of this * `BinaryHeap::into_vec` - plus a `Into` impl * `BinaryHeap::into_sorted_vec` Deprecated APIs * `slice::ref_slice` * `slice::mut_ref_slice` * `iter::{range_inclusive, RangeInclusive}` * `std::dynamic_lib` Closes rust-lang#27706 Closes rust-lang#27725 cc rust-lang#27726 (align not stabilized yet) Closes rust-lang#27734 Closes rust-lang#27737 Closes rust-lang#27742 Closes rust-lang#27743 Closes rust-lang#27772 Closes rust-lang#27774 Closes rust-lang#27777 Closes rust-lang#27781 cc rust-lang#27788 (a few remaining methods though) Closes rust-lang#27790 Closes rust-lang#27793 Closes rust-lang#27796 Closes rust-lang#27810 cc rust-lang#28147 (not all parts stabilized)

alexcrichton · 2015-10-25T16:36:47Z

@bors: r=brson ff49733

bors · 2015-10-25T16:38:39Z

⌛ Testing commit ff49733 with merge e02ada6...

This commit stabilizes and deprecates library APIs whose FCP has closed in the last cycle, specifically: Stabilized APIs: * `fs::canonicalize` * `Path::{metadata, symlink_metadata, canonicalize, read_link, read_dir, exists, is_file, is_dir}` - all moved to inherent methods from the `PathExt` trait. * `Formatter::fill` * `Formatter::width` * `Formatter::precision` * `Formatter::sign_plus` * `Formatter::sign_minus` * `Formatter::alternate` * `Formatter::sign_aware_zero_pad` * `string::ParseError` * `Utf8Error::valid_up_to` * `Iterator::{cmp, partial_cmp, eq, ne, lt, le, gt, ge}` * `<[T]>::split_{first,last}{,_mut}` * `Condvar::wait_timeout` - note that `wait_timeout_ms` is not yet deprecated but will be once 1.5 is released. * `str::{R,}MatchIndices` * `str::{r,}match_indices` * `char::from_u32_unchecked` * `VecDeque::insert` * `VecDeque::shrink_to_fit` * `VecDeque::as_slices` * `VecDeque::as_mut_slices` * `VecDeque::swap_remove_front` - (renamed from `swap_front_remove`) * `VecDeque::swap_remove_back` - (renamed from `swap_back_remove`) * `Vec::resize` * `str::slice_mut_unchecked` * `FileTypeExt` * `FileTypeExt::{is_block_device, is_char_device, is_fifo, is_socket}` * `BinaryHeap::from` - `from_vec` deprecated in favor of this * `BinaryHeap::into_vec` - plus a `Into` impl * `BinaryHeap::into_sorted_vec` Deprecated APIs * `slice::ref_slice` * `slice::mut_ref_slice` * `iter::{range_inclusive, RangeInclusive}` * `std::dynamic_lib` Closes #27706 Closes #27725 cc #27726 (align not stabilized yet) Closes #27734 Closes #27737 Closes #27742 Closes #27743 Closes #27772 Closes #27774 Closes #27777 Closes #27781 cc #27788 (a few remaining methods though) Closes #27790 Closes #27793 Closes #27796 Closes #27810 cc #28147 (not all parts stabilized)

bors · 2015-10-25T18:34:27Z

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-gnu-32-nopt-t, auto-win-gnu-32-opt, auto-win-gnu-64-nopt-t, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-opt

rust-highfive assigned aturon Oct 23, 2015

rust-highfive assigned brson and unassigned aturon Oct 23, 2015

brson added the relnotes Marks issues that should be documented in the release notes of the next release. label Oct 24, 2015

alexcrichton force-pushed the stabilize-1.5 branch from a84f62b to 99c0eaa Compare October 24, 2015 18:50

alexcrichton force-pushed the stabilize-1.5 branch from 99c0eaa to 68162b4 Compare October 25, 2015 02:22

alexcrichton force-pushed the stabilize-1.5 branch from 68162b4 to 8cab27e Compare October 25, 2015 04:32

alexcrichton force-pushed the stabilize-1.5 branch from 8cab27e to ff49733 Compare October 25, 2015 16:36

bors merged commit ff49733 into rust-lang:master Oct 25, 2015

This was referenced Oct 25, 2015

Rework stability annotation pass #29083

Merged

Preliminary support for MIR in trans #29217

Merged

Make short string hashing 30% faster by splitting Hash::hash_end from Hash::hash #29139

Closed

alexcrichton deleted the stabilize-1.5 branch October 27, 2015 21:40

frewsxcv mentioned this pull request Dec 5, 2015

Implement Ord and PartialOrd for UniCase<AsRef<str>> seanmonstar/unicase#7

Merged

Uh oh!

std: Stabilize library APIs for 1.5 #29254

std: Stabilize library APIs for 1.5 #29254

Uh oh!

Conversation

alexcrichton commented Oct 23, 2015

Uh oh!

rust-highfive commented Oct 23, 2015

Uh oh!

alexcrichton commented Oct 23, 2015

Uh oh!

alexcrichton commented Oct 23, 2015

Uh oh!

brson commented Oct 24, 2015

Uh oh!

bors commented Oct 24, 2015

Uh oh!

bors commented Oct 24, 2015

Uh oh!

bors commented Oct 24, 2015

Uh oh!

alexcrichton commented Oct 24, 2015

Uh oh!

bors commented Oct 25, 2015

Uh oh!

bors commented Oct 25, 2015

Uh oh!

alexcrichton commented Oct 25, 2015

Uh oh!

bors commented Oct 25, 2015

Uh oh!

bors commented Oct 25, 2015

Uh oh!

alexcrichton commented Oct 25, 2015

Uh oh!

bors commented Oct 25, 2015

Uh oh!

bors commented Oct 25, 2015

Uh oh!

alexcrichton commented Oct 25, 2015

Uh oh!

bors commented Oct 25, 2015

Uh oh!

bors commented Oct 25, 2015

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants