Repository navigation
Tracking issue for VecDeque Extras #27788
Description
This covers the deque_extras blanket feature, which should probably be sharded more in the future. It covers:
truncateresizeas_slicesas_mut_slicesswap_back_removeswap_front_remove
Some notes:
truncateandresizeare strange because they aren't directional (they just truncate off the back). Need work.as_slicesandas_mut_slicesseem good to go. A bit niche, but so is VecDeque. Maybe move themutto the end. RFC'd and everything.swap_back_removeandswap_front_removealso seem good to go. Maybe move the directional specifier to the end. RFC'd and everything.
Activity
eefriedman commentedon Sep 2, 2015
shrink_to_fitandinsertare now also part ofdeque_extras.sfackler commentedon Sep 17, 2015
I think we can pretty easily stabilize
as_slicesandas_mut_slices. Not sure about the others.alexcrichton commentedon Sep 24, 2015
This issue is now entering its cycle-long FCP for stabilization in 1.5
Specifically the
as_slicesandas_mut_slicesalongswap_*_removemethods are being considered for stabilization. We are also considering renaming the swapping methods.llogiq commentedon Oct 21, 2015
@alexcrichton How should the swapping methods be named?
alexcrichton commentedon Oct 21, 2015
@llogiq as mentioned in the issue description, the other candidate names would be
swap_remove_backandswap_remove_frontalexcrichton commentedon Oct 22, 2015
The libs team discussed this during triage today and the decision was to stabilize:
insertshrink_to_fitas_slicesas_mut_slicesswap_remove_front(renamed fromswap_front_remove)swap_remove_back(renamed fromswap_back_remove)Gankra commentedon Oct 22, 2015
Oh, we forgot to discuss as_mut_slices vs as_slices_mut.
I think we should move muts to the back as much as possible, even if in this case we're making "mutable slices", it's still the _mut variant of as_slices.
alexcrichton commentedon Oct 22, 2015
Hm I'm not sure I'd follow the same reasoning, in method names types like
&mut [T]and*mut Tare referred to asmut_sliceandmut_ptr. We've always known about this with regards to the_mut-at-the-end convention, so I would feel that these methods are correctly named.Gankra commentedon Oct 22, 2015
Yeah I've been a bit ambivalent about that naming scheme, but I guess it's
a bit too late for that!
On Thu, Oct 22, 2015 at 11:18 AM, Alex Crichton notifications@github.com
wrote:
6 remaining items
std: Stabilize library APIs for 1.5
Auto merge of #29254 - alexcrichton:stabilize-1.5, r=brson
sfackler commentedon Jan 19, 2017
The only remaining unstable methods on
VecDequearetruncateandresize. Nominating to stabilize.@rfcbot fcp merge
rfcbot commentedon Jan 19, 2017
Team member @sfackler has proposed to merge this. The next step is review by the rest of the tagged teams:
No concerns currently listed.
Once these reviewers reach consensus, this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!
See this document for info about what commands tagged team members can give me.
rfcbot commentedon Jan 23, 2017
🔔 This is now entering its final comment period, as per the review above. 🔔