Tracking issue for unix::FileTypeExt #27796

Activity

1. alexcrichton

   added

   E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

   A-io

   T-libs-api[DEPRECATED; DO NOT USE][DEPRECATED; DO NOT USE]

   B-unstableBlocker: Implemented in the nightly compiler and unstable.Blocker: Implemented in the nightly compiler and unstable.

   on Aug 13, 2015
2. alexcrichton commented on Sep 17, 2015

   

   alexcrichton

   on Sep 17, 2015

   MemberAuthor

   More actions

   Nominating for 1.5 resolution
3. alexcrichton

   added

   I-nominated

   on Sep 17, 2015
4. lambda-fairy commented on Sep 19, 2015

   

   lambda-fairy

   on Sep 19, 2015

   Contributor

   More actions

   Since the file types are mutually exclusive, would it be better to return an enum instead?

   Though I think the primary use case would be "is the type of this == X" so the current API would be fine.
5. SimonSapin commented on Sep 19, 2015

   

   SimonSapin

   on Sep 19, 2015

   Contributor

   More actions

   std::os::unix::fs::FileTypeExt only exists on Unix platforms, and is deliberately a trait (rather than conditionally-compiled inherent methods) so that you have to import it to use it, and see (with the os::unix bit) that you’re using something platform-specific. I don’t know if the same separation would be possible with enum variants.
6. alexcrichton commented on Sep 24, 2015

   

   alexcrichton

   on Sep 24, 2015

   MemberAuthor

   More actions

   This issue is now entering its cycle-long FCP for stabilization in 1.5
7. alexcrichton

   added

   final-comment-periodIn the final comment period and will be merged soon unless new substantive objections are raised.In the final comment period and will be merged soon unless new substantive objections are raised.

   and removed

   I-nominated

   on Sep 24, 2015
8. steveklabnik

   added this to the 1.5 milestone on Oct 1, 2015
9. Manishearth

   removed

   E-easyCall for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.

   on Oct 2, 2015
10. alexcrichton commented on Oct 22, 2015

    

    alexcrichton

    on Oct 22, 2015

    MemberAuthor

    More actions

    The libs team discussed this today and the decision was to stabilize.
11. alexcrichton

    added a commit that references this issue on Oct 25, 2015

    std: Stabilize library APIs for 1.5

    ...

    This issue will close once commit ff49733 is merged into the 'incoming' branch.

    ff49733
12. bors

    added a commit that references this issue on Oct 25, 2015

    Auto merge of #29254 - alexcrichton:stabilize-1.5, r=brson

    ...

    This issue will close once commit e02ada6 is merged into the 'main' branch.

    e02ada6
13. bors

    closed this as completedin #29254on Oct 25, 2015