Rollup of PRs in the queue; Wednesday #22796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than stabilize on the current API, we're going to punt this concern to crates.io, to allow for faster iteration. If you need this functionality, you might look at https://github.com/carllerche/syncbox [breaking-change]
This commit removes many unnecessary `unsafe impl` blocks as well as pushing the needed implementations to the lowest level possible. I noticed that the bounds for `RwLock` are a little off when reviewing rust-lang#22574 and wanted to ensure that we had our story straight on these implementations.
This affects the `set_non_blocking` function which cannot fail for Unix or Windows, given correct parameters. Additionally, the short UDP write error case has been removed as there is no such thing as "short UDP writes", instead, the operating system will error out if the application tries to send a packet larger than the MTU of the network path.
If the filename for a path is `None` then we know that the creation of the parent directory created the whole path so there's no need to retry the call to `create_dir`. Closes rust-lang#22737
Currently we have a `set_mode` mutator, so this just adds the pairing of a `mode` accessor to read the value. Closes rust-lang#22738
Tests often use `vec![1, 2, 3]` instead of shorter and faster `[1, 2, 3]`. This patch removes a lot of unnecessary `vec!`s. Hopefully, the tests will compile and run a bit faster.
This affects the `set_non_blocking` function which cannot fail for Unix or Windows, given correct parameters. Additionally, the short UDP write error case has been removed as there is no such thing as \"short UDP writes\", instead, the operating system will error out if the application tries to send a packet larger than the MTU of the network path.
…hton Makes Rust less amusing by fixing [rust-lang#22745](rust-lang#22745)
…hton This allows selectively disabling the lint for individual methods or traits.
…excrichton This commit has already been merged in rust-lang#21774, but i think it has been accidently overriden by rust-lang#22584 and rust-lang#22480. r? @alexcrichton
…r=alexcrichton Fixes rust-lang#22342
I tried to follow [the style guide][1] as much as possible. This is just from some random readings of the code, so no guarantees on completeness, even in the edited files. [1]: http://aturon.github.io/style/README.html
Apply borrowck to fns that appear in const declarations. Fixes rust-lang#22382. r? @eddyb
Specifically, the following actions were taken: * The `copy_memory` and `copy_nonoverlapping_memory` functions to drop the `_memory` suffix (as it's implied by the functionality). Both functions are now marked as `#[stable]`. * The `set_memory` function was renamed to `write_bytes` and is now stable. * The `zero_memory` function is now deprecated in favor of `write_bytes` directly. * The `Unique` pointer type is now behind its own feature gate called `unique` to facilitate future stabilization. * All type parameters now are `T: ?Sized` wherever possible and new clauses were added to the `offset` functions to require that the type is sized. [breaking-change]
|
⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-win-32-nopt-t, auto-win-32-opt... |
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors: retry |
|
@bors: force |
1 similar comment
|
@bors: force |
|
⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-win-32-nopt-t, auto-win-32-opt... |
|
💔 Test failed - auto-win-32-nopt-t |
|
@bors retry |
|
@bors: force |
|
@bors: force clean |
|
⌛ Testing commit 357b41b with merge f7d562c... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry force |
|
⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt... |
|
💔 Test failed - auto-win-32-opt |
|
@bors: retry force clean |
|
⌛ Testing commit 357b41b with merge 72a5ee4... |
|
💔 Test failed - auto-mac-32-opt |
|
@bors retry force clean |
bors
added a commit
that referenced
this pull request
Feb 25, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.