Use arrays instead of vectors in tests #22623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ 2e91dc0 |
|
Needs rebase. |
|
Rebased and removed some more |
| @@ -480,7 +480,7 @@ impl<T: Ord> BinaryHeap<T> { | |||
| /// heap.push(3); | |||
| /// | |||
| /// let vec = heap.into_sorted_vec(); | |||
| /// assert_eq!(vec, vec![1, 2, 3, 4, 5, 6, 7]); | |||
There was a problem hiding this comment.
Hey, it works. Never mind :)
|
It didn't pass local make check, I've fixed the broken test. |
Manishearth
added a commit
to Manishearth/rust
that referenced
this pull request
Feb 24, 2015
Tests often use `vec![1, 2, 3]` instead of shorter and faster `[1, 2, 3]`. This patch removes a lot of unnecessary `vec!`s. Hopefully, the tests will compile and run a bit faster.
|
⌛ Testing commit c11807d with merge 0e5d8b8... |
|
💔 Test failed - auto-linux-64-x-android-t |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests often use
vec![1, 2, 3]instead of shorter and faster[1, 2, 3].This patch removes a lot of unnecessary
vec!s. Hopefully, the tests will compile and run a bit faster.