-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Stop parsing "-" as integer, fixes #22745 #22747
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see CONTRIBUTING.md for more information. |
@@ -122,4 +122,9 @@ mod test { | |||
assert_eq!("-9223372036854775808".parse::<i64>().ok(), Some(i64_val)); | |||
assert_eq!("-9223372036854775809".parse::<i64>().ok(), None); | |||
} | |||
|
|||
#[test] | |||
test_int_from_minus_sign() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing fn
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lifthrasiir Sorry, forgot to push after testing.
…hton Makes Rust less amusing by fixing [rust-lang#22745](rust-lang#22745)
⌛ Testing commit a9f6f4b with merge 7eca404... |
💔 Test failed - auto-linux-32-opt |
Makes Rust less amusing by fixing #22745