Port #[prelude_import] to the attribute parser #152550
Open
+44
−30
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Some changes occurred in compiler/rustc_hir/src/attrs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_passes/src/check_attr.rs cc @jdonszelmann, @JonathanBrouwer Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
9 tasks
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
bot
added
S-waiting-on-bors
euclio
reviewed
Feb 12, 2026
| #![feature(fn_delegation)] | ||
| extern crate std; | ||
| #[prelude_import] | ||
| #[attr = PreludeImport] |
Contributor
There was a problem hiding this comment.
Why did the pretty printing change?
Contributor
There was a problem hiding this comment.
Parsed attribute don't pretty print into valid syntax, this is fine because the hir-pretty is only meant to be developer readable and does not need to be valid Rust.
We can make pretty printers for parsed attributes, but we don't when we don't have a reason to
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Feb 13, 2026
…ouwer Port #[prelude_import] to the attribute parser Tracking issue: rust-lang#131229 r? @JonathanBrouwer Didn't change any use-sites of it in the compiler
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 13, 2026
Rollup of 18 pull requests Successful merges: - #150551 (Compute localized outlives constraints lazily) - #150752 (Update libc to v0.2.181) - #150988 (Improve code suggestion for incorrect macro_rules! usage) - #152422 (Change query proc macro to be more rust-analyzer friendly) - #152496 (Fix multi-cgu+debug builds using autodiff by delaying autodiff till lto) - #152514 (Collect active query jobs into struct `QueryJobMap`) - #152520 (Don't use `DepContext` in `rustc_middle::traits::cache`) - #152528 (Support serializing CodegenContext) - #152082 (Move tests) - #152232 (Add must_use for FileTimes) - #152329 (Simplify parallel! macro) - #152444 (`-Znext-solver` Prevent committing unfulfilled unsized coercion) - #152486 (remove redundant backchain attribute in codegen) - #152519 (Fix feature gating for new `try bikeshed` expressions) - #152529 (sparc64: enable abi compatibility test) - #152548 (reject inline const patterns pre-expansion) - #152550 (Port #[prelude_import] to the attribute parser) - #152552 (Add 2048-bit HvxVectorPair support to Hexagon SIMD ABI checks)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Feb 13, 2026
…ouwer Port #[prelude_import] to the attribute parser Tracking issue: rust-lang#131229 r? @JonathanBrouwer Didn't change any use-sites of it in the compiler
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue: #131229
r? @JonathanBrouwer
Didn't change any use-sites of it in the compiler