Fix multi-cgu+debug builds using autodiff by delaying autodiff till lto #152496
+13
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-LLVM
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
fix-autodiff-dbg-build
branch
from
6daf565 to
f3db21d
Compare
This comment has been minimized.
This comment has been minimized.
ZuseZ4
force-pushed
the
fix-autodiff-dbg-build
branch
from
f3db21d to
c89a89b
Compare
ZuseZ4
commented
Feb 11, 2026
| // In the case of debug builds with multiple codegen units, we might not | ||
| // have all function definitions available during the early compiler | ||
| // invocations. We therefore wait for the final lto step to run Enzyme. | ||
| if (EnzymePtr && IsLTO) { |
Member
Author
There was a problem hiding this comment.
I could have checked for fat-lto only, since that's what we require atm. But it seems to work atm. and every once in a while I experiment with lowering our requirements from fat to thin lto, so I think it's fine.
Member
|
I had expected we already did this given that fat LTO is mandatory. @bors r+ |
Contributor
rust-bors
bot
added
S-waiting-on-bors
Member
Author
|
We used to, but the change from static/dynamic linking of Enzyme to dlopen broke it. I had forgotten to add the run-make autododiff tests to our docs, and we don't run them in CI by default, so we just didn't notice. |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 12, 2026
…jorn3 Fix multi-cgu+debug builds using autodiff by delaying autodiff till lto fixes: rust-lang#152470 r? @bjorn3
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Feb 12, 2026
…jorn3 Fix multi-cgu+debug builds using autodiff by delaying autodiff till lto fixes: rust-lang#152470 r? @bjorn3
rust-bors bot
pushed a commit
that referenced
this pull request
Feb 12, 2026
…uwer Rollup of 11 pull requests Successful merges: - #146901 (Support AVRTiny devices in AVR inline assembly) - #150988 (Improve code suggestion for incorrect macro_rules! usage) - #152422 (Change query proc macro to be more rust-analyzer friendly) - #152496 (Fix multi-cgu+debug builds using autodiff by delaying autodiff till lto) - #152520 (Don't use `DepContext` in `rustc_middle::traits::cache`) - #152528 (Support serializing CodegenContext) - #152082 (Move tests) - #152444 (`-Znext-solver` Prevent committing unfulfilled unsized coercion) - #152486 (remove redundant backchain attribute in codegen) - #152529 (sparc64: enable abi compatibility test) - #152548 (reject inline const patterns pre-expansion)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #152470
r? @bjorn3