Skip to content

Conversation

@folkertdev
Copy link
Contributor

fixes #115336

We can now remove the exceptions for sparc64 from the abi compatibility tests (since #142680).

I was also able to remove a cfg for mips64. The remaining (tested) issues seem to be around how f64 is handled there.

cc @RalfJung
r? tgross35

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 12, 2026
@rustbot rustbot added the T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. label Feb 12, 2026
@rustbot
Copy link
Collaborator

rustbot commented Feb 12, 2026

tgross35 is currently at their maximum review capacity.
They may take a while to respond.

@RalfJung
Copy link
Member

Hm, I wonder what changed on the MIPS side to make that test pass now... shrug.

r=me when CI is happy.
@bors delegate+

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 12, 2026

✌️ @folkertdev, you can now approve this pull request!

If @RalfJung told you to "r=me" after making some further change, then please make that change and post @bors r=RalfJung.

@folkertdev
Copy link
Contributor Author

@bors r=RalfJung

@rust-bors
Copy link
Contributor

rust-bors bot commented Feb 12, 2026

📌 Commit d8ed639 has been approved by RalfJung

It is now in the queue for this repository.

@rust-bors rust-bors bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2026
@folkertdev
Copy link
Contributor Author

@bors rollup

JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 12, 2026
…at-test, r=RalfJung

sparc64: enable abi compatibility test

fixes rust-lang#115336

We can now remove the exceptions for sparc64 from the abi compatibility tests (since rust-lang#142680).

I was also able to remove a cfg for mips64. The remaining (tested) issues seem to be around how `f64` is handled there.

cc @RalfJung
r? tgross35
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Feb 12, 2026
…at-test, r=RalfJung

sparc64: enable abi compatibility test

fixes rust-lang#115336

We can now remove the exceptions for sparc64 from the abi compatibility tests (since rust-lang#142680).

I was also able to remove a cfg for mips64. The remaining (tested) issues seem to be around how `f64` is handled there.

cc @RalfJung
r? tgross35
rust-bors bot pushed a commit that referenced this pull request Feb 12, 2026
…uwer

Rollup of 11 pull requests

Successful merges:

 - #146901 (Support AVRTiny devices in AVR inline assembly)
 - #150988 (Improve code suggestion for incorrect macro_rules! usage)
 - #152422 (Change query proc macro to be more rust-analyzer friendly)
 - #152496 (Fix multi-cgu+debug builds using autodiff by delaying autodiff till lto)
 - #152520 (Don't use `DepContext` in `rustc_middle::traits::cache`)
 - #152528 (Support serializing CodegenContext)
 - #152082 (Move tests)
 - #152444 (`-Znext-solver` Prevent committing unfulfilled unsized coercion)
 - #152486 (remove redundant backchain attribute in codegen)
 - #152529 (sparc64: enable abi compatibility test)
 - #152548 (reject inline const patterns pre-expansion)
Zalathar added a commit to Zalathar/rust that referenced this pull request Feb 13, 2026
…at-test, r=RalfJung

sparc64: enable abi compatibility test

fixes rust-lang#115336

We can now remove the exceptions for sparc64 from the abi compatibility tests (since rust-lang#142680).

I was also able to remove a cfg for mips64. The remaining (tested) issues seem to be around how `f64` is handled there.

cc @RalfJung
r? tgross35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

extern "C" fn on sparc64 targets does not respect repr(transparent)

4 participants