Skip to content

mgca: Finish implementation of #[type_const] #148716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

mgca: Finish implementation of #[type_const] #148716

wants to merge 4 commits into from
+536 −170

Conversation

@camelid
Copy link
Member

@camelid camelid commented Nov 8, 2025 •
edited
Loading

tracking issue: #132980
fixes #140729
fixes #140860

  • Fix #[type_const] attribute placement validation
  • Perform WF-checking on type_const RHS's
  • Check type_const type is ConstParamTy_ and that RHS matches it
  • Check that impls of #[type_const] consts also have the attr

r? @BoxyUwU

@rustbot
Copy link
Collaborator

rustbot commented Nov 8, 2025

BoxyUwU is currently at their maximum review capacity.
They may take a while to respond.

@rustbot rustbot added A-attributes Area: Attributes (`#[…]`, `#![…]`) S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-clippy Relevant to the Clippy team. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 8, 2025
@camelid camelid added the A-const-generics Area: const generics (parameters and arguments) label Nov 8, 2025
@BoxyUwU BoxyUwU removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. T-clippy Relevant to the Clippy team. labels Nov 8, 2025
@camelid camelid added F-min_generic_const_args `#![feature(min_generic_const_args)]` and removed WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 8, 2025
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@camelid camelid mentioned this pull request Nov 8, 2025
Open
18 tasks
@rustbot rustbot added T-clippy Relevant to the Clippy team. T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Nov 8, 2025
@camelid camelid marked this pull request as ready for review November 9, 2025 04:06
@rustbot
Copy link
Collaborator

rustbot commented Nov 9, 2025

Some changes occurred in compiler/rustc_attr_parsing

cc @jdonszelmann

Some changes occurred in compiler/rustc_passes/src/check_attr.rs

cc @jdonszelmann

This PR changes a file inside tests/crashes. If a crash was fixed, please move into the corresponding ui subdir and add 'Fixes #' to the PR description to autoclose the issue upon merge.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 9, 2025
@BoxyUwU BoxyUwU removed WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) T-rustdoc-frontend Relevant to the rustdoc-frontend team, which will review and decide on the web UI/UX output. T-rustfmt Relevant to the rustfmt team, which will review and decide on the PR/issue. T-clippy Relevant to the Clippy team. labels Nov 9, 2025
BoxyUwU
BoxyUwU approved these changes Nov 9, 2025
View reviewed changes
Copy link
Member

@BoxyUwU BoxyUwU left a comment •
edited by rustbot
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, will r+ once CI passes

View changes since this review

@BoxyUwU
Copy link
Member

BoxyUwU commented Nov 9, 2025

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Nov 9, 2025

📌 Commit db2fbdb has been approved by BoxyUwU

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2025
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#148716 - camelid:finish-type_const, r=BoxyUwU
36be4d6 
mgca: Finish implementation of `#[type_const]`

tracking issue: rust-lang#132980
fixes rust-lang#140729
fixes rust-lang#140860

- **Fix `#[type_const]` attribute placement validation**
- **Perform WF-checking on type_const RHS's**
- **Check type_const type is ConstParamTy_ and that RHS matches it**
- **Check that impls of `#[type_const]` consts also have the attr**

r? `@BoxyUwU`
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 9, 2025
Closed
bors added a commit that referenced this pull request Nov 9, 2025
@bors
Auto merge of #148741 - matthiaskrgr:rollup-1gnpxj6, r=matthiaskrgr
6fa1dd8 
Rollup of 10 pull requests

Successful merges:

 - #148608 (Add test for --test-builder success path)
 - #148683 (Remove `#[const_trait]`)
 - #148687 (std: use a non-poisoning `RwLock` for the panic hook)
 - #148709 (fix: disable self-contained linker when bootstrap-override-lld is set)
 - #148716 (mgca: Finish implementation of `#[type_const]`)
 - #148722 (Add Crystal Durham to .mailmap)
 - #148723 (bootstrap: Render doctest timing reports as text, not JSON)
 - #148724 (tidy: Don't bypass stderr output capture in unit tests)
 - #148734 (miri subtree update)
 - #148736 (Fix typo in unstable-book link)

r? `@ghost`
`@rustbot` modify labels: rollup
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#148716 - camelid:finish-type_const, r=BoxyUwU
73ae0bf 
mgca: Finish implementation of `#[type_const]`

tracking issue: rust-lang#132980
fixes rust-lang#140729
fixes rust-lang#140860

- **Fix `#[type_const]` attribute placement validation**
- **Perform WF-checking on type_const RHS's**
- **Check type_const type is ConstParamTy_ and that RHS matches it**
- **Check that impls of `#[type_const]` consts also have the attr**

r? ``@BoxyUwU``
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 9, 2025
@matthiaskrgr
Rollup merge of rust-lang#148716 - camelid:finish-type_const, r=BoxyUwU
7e9b67d 
mgca: Finish implementation of `#[type_const]`

tracking issue: rust-lang#132980
fixes rust-lang#140729
fixes rust-lang#140860

- **Fix `#[type_const]` attribute placement validation**
- **Perform WF-checking on type_const RHS's**
- **Check type_const type is ConstParamTy_ and that RHS matches it**
- **Check that impls of `#[type_const]` consts also have the attr**

r? ```@BoxyUwU```
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 9, 2025
Open
bors added a commit that referenced this pull request Nov 9, 2025
@bors
Auto merge of #148753 - matthiaskrgr:rollup-48jzbqw, r=matthiaskrgr
86b95eb 
Rollup of 10 pull requests

Successful merges:

 - #148683 (Remove `#[const_trait]`)
 - #148687 (std: use a non-poisoning `RwLock` for the panic hook)
 - #148709 (fix: disable self-contained linker when bootstrap-override-lld is set)
 - #148716 (mgca: Finish implementation of `#[type_const]`)
 - #148722 (Add Crystal Durham to .mailmap)
 - #148723 (bootstrap: Render doctest timing reports as text, not JSON)
 - #148724 (tidy: Don't bypass stderr output capture in unit tests)
 - #148734 (miri subtree update)
 - #148736 (Fix typo in unstable-book link)
 - #148744 (Add myself(chenyukang) to the review rotation)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BoxyUwU BoxyUwU BoxyUwU approved these changes

Assignees

@BoxyUwU BoxyUwU

Labels

A-attributes Area: Attributes (`#[…]`, `#![…]`) A-const-generics Area: const generics (parameters and arguments) F-min_generic_const_args `#![feature(min_generic_const_args)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

ICE: normalizing free const aliases in the type system is unsupported ICE:normalizing free const aliases in the type system is unsupported

5 participants

@camelid @rustbot @rust-log-analyzer @BoxyUwU @bors