Add test for --test-builder success path #148608

osamakader · 2025-11-06T22:05:19Z

rustbot · 2025-11-06T22:05:24Z

jieyouxu is currently at their maximum review capacity.
They may take a while to respond.

rustbot · 2025-11-06T22:05:25Z

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Adds missing test coverage for rustdoc's `--test-builder` option. The existing test only covered the error case (non-executable builder). This PR adds: - A custom test builder that logs arguments and forwards to rustc - A test verifying that `--test-builder` successfully invokes the custom builder with rustc-style arguments - Improved comments explaining both the error and success test scenarios The test validates that custom builders can properly intercept and handle doctest compilation. Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>

jieyouxu · 2025-11-07T02:03:49Z

r? rustdoc

GuillaumeGomez · 2025-11-07T10:18:41Z

Much appreciated, thanks!

@bors r+ rollup

bors · 2025-11-07T10:18:44Z

📌 Commit 8075c98 has been approved by GuillaumeGomez

It is now in the queue for this repository.

…llaumeGomez Add test for --test-builder success path Fixes rust-lang#148586

Rollup of 5 pull requests Successful merges: - #145656 (Stabilize s390x `vector` target feature and `is_s390x_feature_detected!` macro) - #148204 (Modify contributor email entries in .mailmap) - #148556 (Fix suggestion for returning async closures) - #148585 ([rustdoc] Replace `print` methods with functions to improve code readability) - #148608 (Add test for --test-builder success path) r? `@ghost` `@rustbot` modify labels: rollup

tests/run-make/rustdoc-test-builder/rmake.rs

GuillaumeGomez · 2025-11-07T13:52:44Z

Failed in #148642.

I think it should only be run on linux.

@bors r-

osamakader · 2025-11-07T14:25:17Z

I'm trying right now to use bare_rustc so we compile for the host architecture even in cross build.

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>

GuillaumeGomez · 2025-11-08T10:52:28Z

Let's confirm your fix works.

@bors try jobs=test-various

Add test for --test-builder success path try-job: test-various

rust-bors · 2025-11-08T11:40:20Z

💔 Test for 1410cf9 failed: CI. Failed jobs:

try - test-various (web logs, extended logs)

osamakader · 2025-11-08T14:01:51Z

@bors try jobs=test-various

rust-bors · 2025-11-08T14:01:53Z

@osamakader: 🔑 Insufficient privileges: not in try users

osamakader · 2025-11-08T14:06:44Z

@GuillaumeGomez Can you please re-trigger the test? I don't have privileges to do so.

GuillaumeGomez · 2025-11-08T14:51:39Z

Need to fix the new issue before that. 😉

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>

osamakader · 2025-11-08T19:38:30Z

@GuillaumeGomez Can you please re-try? thanks.

GuillaumeGomez · 2025-11-08T20:28:26Z

Here we go!

@bors try jobs=test-various

Add test for --test-builder success path try-job: test-various

rust-bors · 2025-11-08T22:51:21Z

☀️ Try build successful (CI)
Build commit: 7eefd77 (7eefd7758b1de3920d206290ad79e7f8d3e7d4bb, parent: fb23dd3c6b120f0d2e55e5f2c69a464df7b35fdf)

GuillaumeGomez · 2025-11-09T10:34:11Z

Seems like we're all good. Thanks!

@bors r+ rollup

bors · 2025-11-09T10:34:14Z

📌 Commit 1c1923f has been approved by GuillaumeGomez

It is now in the queue for this repository.

…llaumeGomez Add test for --test-builder success path Fixes rust-lang#148586

jieyouxu · 2025-11-09T14:09:51Z

tests/run-make/rustdoc-test-builder/rmake.rs

+    // Some targets (for example wasm) cannot execute doctests directly even with a runner,
+    // so only exercise the success path when the target can run on the host.
+    let target = std::env::var("TARGET").expect("TARGET must be set");
+    if target.contains("wasm") {
+        return;
+    }


Suggestion: sorry I didn't look at this, but this should instead use //@ ignore-wasm or //@ ignore-cross-compile (if this is host-only), otherwise this will show as test pass on WASM but in reality nothing is checked. Since this is in a rollup, it can be done as a follow-up.

(Also, there is a run_make_support::target() helper for what you're doing here.)

Thanks @jieyouxu. I’d actually prefer to keep the test running on wasm: the failing-path check (non-executable builder should error without panicking) still runs there, so the test isn’t a no-op even after we skip the success branch. I’ll switch the guard to use run_make_support::target() for clarity in a followup PR.

Rollup of 10 pull requests Successful merges: - #148608 (Add test for --test-builder success path) - #148683 (Remove `#[const_trait]`) - #148687 (std: use a non-poisoning `RwLock` for the panic hook) - #148709 (fix: disable self-contained linker when bootstrap-override-lld is set) - #148716 (mgca: Finish implementation of `#[type_const]`) - #148722 (Add Crystal Durham to .mailmap) - #148723 (bootstrap: Render doctest timing reports as text, not JSON) - #148724 (tidy: Don't bypass stderr output capture in unit tests) - #148734 (miri subtree update) - #148736 (Fix typo in unstable-book link) r? `@ghost` `@rustbot` modify labels: rollup

rustbot assigned jieyouxu Nov 6, 2025

rustbot added A-run-make Area: port run-make Makefiles to rmake.rs S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Nov 6, 2025

This comment has been minimized.

Sign in to view

osamakader force-pushed the doc-test-builder branch from 97b721d to a95ac0c Compare November 6, 2025 22:17

This comment has been minimized.

Sign in to view

osamakader force-pushed the doc-test-builder branch from a95ac0c to 8075c98 Compare November 6, 2025 22:24

rustbot added the T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. label Nov 7, 2025

rustbot assigned GuillaumeGomez and unassigned jieyouxu Nov 7, 2025

GuillaumeGomez approved these changes Nov 7, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 7, 2025

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Nov 7, 2025

Rollup merge of rust-lang#148608 - osamakader:doc-test-builder, r=Gui…

1f80593

…llaumeGomez Add test for --test-builder success path Fixes rust-lang#148586

GuillaumeGomez mentioned this pull request Nov 7, 2025

Rollup of 5 pull requests #148642

Closed

GuillaumeGomez reviewed Nov 7, 2025

View reviewed changes

tests/run-make/rustdoc-test-builder/rmake.rs Show resolved Hide resolved

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 7, 2025

use bare_rustc to keep host toolchain

09385f9

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>

osamakader requested a review from GuillaumeGomez November 7, 2025 18:59

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 7, 2025

rust-bors bot added a commit that referenced this pull request Nov 8, 2025

Auto merge of #148608 - osamakader:doc-test-builder, r=<try>

1410cf9

Add test for --test-builder success path try-job: test-various

This comment has been minimized.

Sign in to view

tests: skip rustdoc test-builder success path when cross-compiling

1c1923f

Signed-off-by: Osama Abdelkader <osama.abdelkader@gmail.com>

osamakader force-pushed the doc-test-builder branch from ab29338 to 1c1923f Compare November 8, 2025 17:42

This comment has been minimized.

Sign in to view

rust-bors bot added a commit that referenced this pull request Nov 8, 2025

Auto merge of #148608 - osamakader:doc-test-builder, r=<try>

7eefd77

Add test for --test-builder success path try-job: test-various

GuillaumeGomez approved these changes Nov 9, 2025

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2025

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Nov 9, 2025

Rollup merge of rust-lang#148608 - osamakader:doc-test-builder, r=Gui…

b9ccb6b

…llaumeGomez Add test for --test-builder success path Fixes rust-lang#148586

matthiaskrgr mentioned this pull request Nov 9, 2025

Rollup of 10 pull requests #148741

Open

jieyouxu reviewed Nov 9, 2025

View reviewed changes

Add test for --test-builder success path #148608

Are you sure you want to change the base?

Add test for --test-builder success path #148608

Conversation

osamakader commented Nov 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented Nov 6, 2025

Uh oh!

rustbot commented Nov 6, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

jieyouxu commented Nov 7, 2025

Uh oh!

GuillaumeGomez commented Nov 7, 2025

Uh oh!

bors commented Nov 7, 2025

Uh oh!

Uh oh!

GuillaumeGomez commented Nov 7, 2025

Uh oh!

osamakader commented Nov 7, 2025

Uh oh!

GuillaumeGomez commented Nov 8, 2025

Uh oh!

This comment has been minimized.

This comment has been minimized.

rust-bors bot commented Nov 8, 2025

Uh oh!

osamakader commented Nov 8, 2025

Uh oh!

rust-bors bot commented Nov 8, 2025

Uh oh!

osamakader commented Nov 8, 2025

Uh oh!

This comment has been minimized.

GuillaumeGomez commented Nov 8, 2025

Uh oh!

osamakader commented Nov 8, 2025

Uh oh!

GuillaumeGomez commented Nov 8, 2025

Uh oh!

This comment has been minimized.

rust-bors bot commented Nov 8, 2025

Uh oh!

GuillaumeGomez commented Nov 9, 2025

Uh oh!

bors commented Nov 9, 2025

Uh oh!

jieyouxu Nov 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

osamakader Nov 9, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

osamakader commented Nov 6, 2025 •

edited

Loading

jieyouxu Nov 9, 2025 •

edited

Loading