Rollup of 10 pull requests #148753

matthiaskrgr · 2025-11-09T16:37:11Z

Successful merges:

Remove #[const_trait] #148683 (Remove #[const_trait])
std: use a non-poisoning RwLock for the panic hook #148687 (std: use a non-poisoning RwLock for the panic hook)
fix: disable self-contained linker when bootstrap-override-lld is set #148709 (fix: disable self-contained linker when bootstrap-override-lld is set)
mgca: Finish implementation of #[type_const] #148716 (mgca: Finish implementation of #[type_const])
Add Crystal Durham to .mailmap #148722 (Add Crystal Durham to .mailmap)
bootstrap: Render doctest timing reports as text, not JSON #148723 (bootstrap: Render doctest timing reports as text, not JSON)
tidy: Don't bypass stderr output capture in unit tests #148724 (tidy: Don't bypass stderr output capture in unit tests)
miri subtree update #148734 (miri subtree update)
Fix typo in unstable-book link #148736 (Fix typo in unstable-book link)
Add myself(chenyukang) to the review rotation #148744 (Add myself(chenyukang) to the review rotation)

r? @ghost
@rustbot modify labels: rollup

This updates the rust-version file to 401ae55.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: 401ae55 Filtered ref: 1bd47ec470de5c7eab11a24bfee0e7f663cd56a2 Upstream diff: rust-lang/rust@5f9dd05...401ae55 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

slightly extend triagebot PR creation message

…more

Remove implementation of LLVM SIMD intrinsics that are not needed anymore

This allows getting rid of all the argument mangling hacks as well as the exported_non_generic_symbols override hack by doing cargo build instead of cargo check. This is also a prerequisite for using native jit mode support in miri that I hope to add to rustc in the future to be used with cg_clif too.

Use the dummy codegen backend

./miri run: verbose by default, add flag to be quiet

This updates the rust-version file to ceb7df7.

Pull recent changes from https://github.com/rust-lang/rust via Josh. Upstream ref: ceb7df7 Filtered ref: cc5fca3f935d6a43e0de7e2ff4c16039b88f5d1c Upstream diff: rust-lang/rust@401ae55...ceb7df7 This merge was created using https://github.com/rust-lang/josh-sync.

Automatic Rustup

…d on writes

…ads are queued

… type

Make pthread and other "native" synchronization objects more resilient

🏳️‍⚧️

In unit tests, writes to stderr that don't use `eprint!` or `eprintln!` will not be captured, and instead interfere with test harness output, making it unreadable.

tidy: Don't bypass stderr output capture in unit tests In unit tests, writes to stderr that don't use `eprint!` or `eprintln!` will not be captured, and instead interfere with test harness output, making it unreadable. <details> <summary><b>Detailed before/after</b></summary> ## Before ```text $ x test tidyselftest --no-doc Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.03s Testing stage1 tidy (aarch64-apple-darwin) Compiling tidy v0.1.0 (/Users/stuart/Dev/rust/rust/src/tools/tidy) Finished `release` profile [optimized + debuginfo] target(s) in 0.23s Running unittests src/lib.rs (build/aarch64-apple-darwin/bootstrap-tools/aarch64-apple-darwin/release/deps/tidy-c33a0cc08cf46c66) running 20 tests tidy [alphabetical-test]: bad:3 found `tidy-alphabetical-start` expecting `tidy-alphabetical-end` tidy [alphabetical-test]: FAIL tidy [alphabetical-test]: bad: reached end of file expecting `tidy-alphabetical-end`tidy [alphabetical-test]: bad:4: line not in alphabetical order tidy [alphabetical-test]: bad:5 found `tidy-alphabetical-end` expecting `tidy-alphabetical-start` tidy [alphabetical-test]: FAIL tidy [alphabetical-test]: FAIL tidy [alphabetical-test].: tidy [alphabetical-test...bad:4: line not in alphabetical order..]: tidy [alphabetical-test]: .. bad:7: line not in alphabetical order tidy [tidy [bad:2 found `tidy-alphabetical-end` expecting `tidy-alphabetical-start` alphabetical-testtidy [tidy [alphabetical-test]: bad:4: line not in alphabetical order .tidy [alphabetical-test]..]alphabetical-testtidy []: bad:4: line not in alphabetical orderalphabetical-testalphabetical-test]: tidy [FAILalphabetical-test ]: FAIL ]: FAIL : FAIL : bad:4: line not in alphabetical order tidy [alphabetical-test]: FAIL tidy [.alphabetical-test]: FAIL .tidy [alphabetical-test]: FAIL ..tidy [alphabetical-test]: bad:3: line not in alphabetical order tidy [alphabetical-test]: FAIL tidy [alphabetical-test]: bad:3: line not in alphabetical order tidy [alphabetical-test]: FAIL ..... test result: ok. 20 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.01ms Running unittests src/main.rs (build/aarch64-apple-darwin/bootstrap-tools/aarch64-apple-darwin/release/deps/rust_tidy-25232a69af4dd751) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 26.88µs finished in 0.255 seconds Build completed successfully in 0:00:00 ``` ## After ```text $ x test tidyselftest --no-doc Building bootstrap Finished `dev` profile [unoptimized] target(s) in 0.03s Testing stage1 tidy (aarch64-apple-darwin) Compiling tidy v0.1.0 (/Users/stuart/Dev/rust/rust/src/tools/tidy) Finished `release` profile [optimized + debuginfo] target(s) in 1.74s Running unittests src/lib.rs (build/aarch64-apple-darwin/bootstrap-tools/aarch64-apple-darwin/release/deps/tidy-c33a0cc08cf46c66) running 20 tests .................... test result: ok. 20 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 1.35ms Running unittests src/main.rs (build/aarch64-apple-darwin/bootstrap-tools/aarch64-apple-darwin/release/deps/rust_tidy-25232a69af4dd751) running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 27.17µs finished in 1.764 seconds Build completed successfully in 0:00:02 ``` </details>

miri subtree update Subtree update of `miri` to rust-lang/miri@7d5ae36. Created using https://github.com/rust-lang/josh-sync. r? ``@ghost``

Fix typo in unstable-book link This prevented the links from being rendered. Sorry for not noticing this before my changes were merged yesterday. Introduced in rust-lang#147935 cc ``@petrochenkov``

… r=jieyouxu Add myself(chenyukang) to the review rotation hope I have more time to catch up 💙

matthiaskrgr · 2025-11-09T16:37:25Z

@bors r+ rollup=never p=5

bors · 2025-11-09T16:37:28Z

📌 Commit a2c4f03 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2025-11-09T16:44:36Z

⌛ Testing commit a2c4f03 with merge 86b95eb...

bors · 2025-11-09T19:56:46Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 86b95eb to master...

rust-timer · 2025-11-09T19:59:38Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#148683	Remove `#[const_trait]`	`47bb4434e5100d20212ab6eb62f7f2f60f149dd6` (link)
#148687	std: use a non-poisoning `RwLock` for the panic hook	`4c9984028876d1523ec966946868b11b0c6f2953` (link)
#148709	fix: disable self-contained linker when bootstrap-override-…	`4b6f122ac27fc5e86eded32065d3d568d4a4851f` (link)
#148716	mgca: Finish implementation of `#[type_const]`	`aa590042a62f9133358f80e8edd08ef14f7c7062` (link)
#148722	Add Crystal Durham to .mailmap	`ed13c5695ded8ee2e87ddfc288257cfb5e4db3ee` (link)
#148723	bootstrap: Render doctest timing reports as text, not JSON	`85fc2d3307281bbf18a85a2b27a08eca07ffb565` (link)
#148724	tidy: Don't bypass stderr output capture in unit tests	`5e5135c7147485452a156e87d67264d3a5194c1c` (link)
#148734	miri subtree update	`d80d37fc4b041dd754582d958d533e0f939b51db` (link)
#148736	Fix typo in unstable-book link	`031103506f8b3560cdbd7c4e7de5cd97dbb0ba08` (link)
#148744	Add myself(chenyukang) to the review rotation	`b95ffa255799dfbd31c78ba250047e4e40f8c560` (link)

previous master: ab67c37c6d

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

github-actions · 2025-11-09T19:59:59Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ab67c37 (parent) -> 86b95eb (this PR)

Test differences

Show 97 test diffs

Stage 1

[crashes] tests/crashes/119783.rs: pass -> [missing] (J1)
[crashes] tests/crashes/140729.rs: pass -> [missing] (J1)
[crashes] tests/crashes/140860.rs: pass -> [missing] (J1)
[crashes] tests/crashes/mgca/type_const-only-in-trait.rs: pass -> [missing] (J1)
[ui] tests/ui/const-generics/mgca/concrete-expr-with-generics-in-env.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/mgca/const-arg-coherence-conflicting-methods.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/mgca/type_const-mismatched-types.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/mgca/type_const-not-constparamty.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/mgca/type_const-on-generic-expr.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/mgca/type_const-only-in-trait.rs: [missing] -> pass (J1)
[ui] tests/ui/const-generics/mgca/using-fnptr-as-type_const.rs: [missing] -> pass (J1)
[ui] tests/ui/traits/const-traits/attr-misuse.rs: pass -> [missing] (J1)

Stage 2

[ui] tests/ui/const-generics/mgca/concrete-expr-with-generics-in-env.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/mgca/const-arg-coherence-conflicting-methods.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/mgca/type_const-mismatched-types.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/mgca/type_const-not-constparamty.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/mgca/type_const-on-generic-expr.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/mgca/type_const-only-in-trait.rs: [missing] -> pass (J0)
[ui] tests/ui/const-generics/mgca/using-fnptr-as-type_const.rs: [missing] -> pass (J0)
[ui] tests/ui/traits/const-traits/attr-misuse.rs: pass -> [missing] (J0)
[crashes] tests/crashes/119783.rs: pass -> [missing] (J2)
[crashes] tests/crashes/140729.rs: pass -> [missing] (J2)
[crashes] tests/crashes/140860.rs: pass -> [missing] (J2)
[crashes] tests/crashes/mgca/type_const-only-in-trait.rs: pass -> [missing] (J2)

Additionally, 73 doctest diffs were found. These are ignored, as they are noisy.

Job group index

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 86b95ebc24092acac75e205d95e84e6d4539601f --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

pr-check-1: 1794.8s -> 1361.8s (-24.1%)
x86_64-gnu-gcc: 3589.0s -> 2797.5s (-22.1%)
aarch64-apple: 7274.2s -> 8804.5s (+21.0%)
aarch64-gnu-debug: 4515.6s -> 3865.9s (-14.4%)
x86_64-rust-for-linux: 3139.3s -> 2705.7s (-13.8%)
dist-aarch64-apple: 5685.5s -> 6462.6s (+13.7%)
aarch64-gnu-llvm-20-2: 2432.7s -> 2141.9s (-12.0%)
dist-x86_64-apple: 6686.6s -> 7449.1s (+11.4%)
x86_64-gnu-llvm-20-1: 3684.3s -> 3280.7s (-11.0%)
tidy: 160.6s -> 177.6s (+10.6%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-11-09T21:16:54Z

Finished benchmarking commit (86b95eb): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

Our most reliable metric. Used to determine the overall result above. However, even this metric can be noisy.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-0.2%	[-0.2%, -0.2%]	1
All ❌✅ (primary)	-	-	0

Max RSS (memory usage)

Results (primary 4.9%, secondary 1.5%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	4.9%	[1.4%, 8.4%]	2
Regressions ❌ (secondary)	4.1%	[4.1%, 4.1%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.2%	[-1.2%, -1.2%]	1
All ❌✅ (primary)	4.9%	[1.4%, 8.4%]	2

Cycles

Results (secondary 4.3%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	4.3%	[4.3%, 4.3%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	-	-	0

Binary size

Results (primary -0.0%, secondary -0.0%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-0.0%	[-0.0%, -0.0%]	7
Improvements ✅ (secondary)	-0.0%	[-0.0%, -0.0%]	32
All ❌✅ (primary)	-0.0%	[-0.0%, -0.0%]	7

Bootstrap: 475.32s -> 476.643s (0.28%)
Artifact size: 391.34 MiB -> 391.27 MiB (-0.02%)

RalfJung and others added 30 commits November 5, 2025 10:52

slightly extend PR creation message

14795f0

Prepare for merging from rust-lang/rust

4384d43

This updates the rust-version file to 401ae55.

fmt

3d08696

Merge pull request rust-lang#4671 from rust-lang/rustup-2025-11-06

29c28b3

Automatic Rustup

Merge pull request rust-lang#4669 from RalfJung/triagebot-welcome

6b394d4

slightly extend triagebot PR creation message

Remove implementation of LLVM SIMD intrinsics that are not needed any…

8d597aa

…more

Merge pull request rust-lang#4667 from eduardosm/remove-intrinsics

2760570

Remove implementation of LLVM SIMD intrinsics that are not needed anymore

Merge pull request rust-lang#4648 from bjorn3/dummy_backend

ccdb1c0

Use the dummy codegen backend

lazy_sync: ensure the cookie fits inside the primitive

7711eb9

./miri run: verbose by default, add flag to be quiet

b8eee76

fix 'cargo miri setup' quietness

384c05f

Merge pull request rust-lang#4665 from RalfJung/run-verbose

4ddc3ad

./miri run: verbose by default, add flag to be quiet

Prepare for merging from rust-lang/rust

f6b751e

This updates the rust-version file to ceb7df7.

Replace #[const_trait] with const in libcore

8aedbf1

Remove #[const_trait]

c262920

Merge pull request rust-lang#4673 from rust-lang/rustup-2025-11-08

f796155

Automatic Rustup

std: use a non-poisoning RwLock for the panic hook

52fd48c

pthread: replace INIT_COOKIE by sync object metadata that gets cleare…

edc13e6

…d on writes

also use new sync obj metadata scheme for INIT_ONCE and os_unfair_lock

ba789c6

throw an error if a synchronization object is read/written while thre…

155b09f

…ads are queued

remove dead code

3c4b29c

also inform sync objcts about deallocation; needs separate AccessKind…

d6b01ab

… type

Merge pull request rust-lang#4672 from RalfJung/sync-objs

e14780a

Make pthread and other "native" synchronization objects more resilient

fix: disable self-contained linker when bootstrap-override-lld is set

7eb5492

Add Crystal Durham to .mailmap

3fdde5f

🏳️‍⚧️

bootstrap: Render doctest timing reports as text, not JSON

610391f

tidy: Don't bypass stderr output capture in unit tests

38ae449

In unit tests, writes to stderr that don't use `eprint!` or `eprintln!` will not be captured, and instead interfere with test harness output, making it unreadable.

matthiaskrgr added 4 commits November 9, 2025 17:37

Rollup merge of rust-lang#148734 - RalfJung:miri, r=RalfJung

2fffcf0

miri subtree update Subtree update of `miri` to rust-lang/miri@7d5ae36. Created using https://github.com/rust-lang/josh-sync. r? ``@ghost``

Rollup merge of rust-lang#148736 - luca3s:fix-typo, r=Zalathar

afa0e75

Fix typo in unstable-book link This prevented the links from being rendered. Sorry for not noticing this before my changes were merged yesterday. Introduced in rust-lang#147935 cc ``@petrochenkov``

Rollup merge of rust-lang#148744 - chenyukang:yukang-add-to-rotation,…

a2c4f03

… r=jieyouxu Add myself(chenyukang) to the review rotation hope I have more time to catch up 💙

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2025

bors added the merged-by-bors This PR was explicitly merged by bors. label Nov 9, 2025

bors merged commit 86b95eb into rust-lang:master Nov 9, 2025
12 checks passed

rustbot added this to the 1.93.0 milestone Nov 9, 2025

This was referenced Nov 9, 2025

Ignore #[doc(hidden)] items when computing trimmed paths for printing #148623

Open

Replace #[rustc_do_not_implement_via_object] with #[rustc_dyn_incompatible_trait] #148637

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 10 pull requests #148753

Rollup of 10 pull requests #148753

matthiaskrgr commented Nov 9, 2025 •

edited by rustbot

Loading

Uh oh!

matthiaskrgr commented Nov 9, 2025

Uh oh!

bors commented Nov 9, 2025

Uh oh!

bors commented Nov 9, 2025

Uh oh!

bors commented Nov 9, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 9, 2025

Uh oh!

github-actions bot commented Nov 9, 2025

Stage 1

Stage 2

Uh oh!

rust-timer commented Nov 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

Rollup of 10 pull requests #148753

Rollup of 10 pull requests #148753

Conversation

matthiaskrgr commented Nov 9, 2025 • edited by rustbot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

matthiaskrgr commented Nov 9, 2025

Uh oh!

bors commented Nov 9, 2025

Uh oh!

bors commented Nov 9, 2025

Uh oh!

bors commented Nov 9, 2025

Uh oh!

Uh oh!

rust-timer commented Nov 9, 2025

Uh oh!

github-actions bot commented Nov 9, 2025

Test differences

Stage 1

Stage 2

Job duration changes

Uh oh!

rust-timer commented Nov 9, 2025

Overall result: ✅ improvements - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

16 participants

matthiaskrgr commented Nov 9, 2025 •

edited by rustbot

Loading