Skip to content

Fixes for building windows-gnullvm hosts #141819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 31, 2025

Conversation

mati865
Copy link
Member

@mati865 mati865 commented May 31, 2025

Split out from: #140772

@rustbot
Copy link
Collaborator

rustbot commented May 31, 2025

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2025
@rustbot
Copy link
Collaborator

rustbot commented May 31, 2025

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

@rustbot rustbot added the T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) label May 31, 2025
Copy link
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@jieyouxu
Copy link
Member

r? jieyouxu @bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 31, 2025

📌 Commit 885184a has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2025
@jieyouxu jieyouxu added the O-windows-gnullvm Target: *-windows-gnullvm label May 31, 2025
bors added a commit that referenced this pull request May 31, 2025
Rollup of 8 pull requests

Successful merges:

 - #140787 (Note expr being cast when encounter NonScalar cast error)
 - #141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods)
 - #141646 (Document what `distcheck` is intended to exercise)
 - #141740 (Hir item kind field order)
 - #141793 (`tests/ui`: A New Order [1/N])
 - #141805 (Update `compiler-builtins` to 0.1.160)
 - #141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows)
 - #141819 (Fixes for building windows-gnullvm hosts)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 23cc24e into rust-lang:master May 31, 2025
9 checks passed
rust-timer added a commit that referenced this pull request May 31, 2025
Rollup merge of #141819 - mati865:windows-gnullvm-host-fixes, r=jieyouxu

Fixes for building windows-gnullvm hosts

Split out from: #140772
@rustbot rustbot added this to the 1.89.0 milestone May 31, 2025
@mati865 mati865 deleted the windows-gnullvm-host-fixes branch May 31, 2025 22:32
github-actions bot pushed a commit to model-checking/verify-rust-std that referenced this pull request Jun 3, 2025
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#140787 (Note expr being cast when encounter NonScalar cast error)
 - rust-lang#141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods)
 - rust-lang#141646 (Document what `distcheck` is intended to exercise)
 - rust-lang#141740 (Hir item kind field order)
 - rust-lang#141793 (`tests/ui`: A New Order [1/N])
 - rust-lang#141805 (Update `compiler-builtins` to 0.1.160)
 - rust-lang#141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows)
 - rust-lang#141819 (Fixes for building windows-gnullvm hosts)

r? `@ghost`
`@rustbot` modify labels: rollup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows-gnullvm Target: *-windows-gnullvm S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants