{aarch64,x86_64}-*-windows-gnullvm: build host tools #140772

mati865 · 2025-05-07T21:22:32Z

This will require MCP, but I suppose we need to know how long it takes to build first.

I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable.

--enable-full-tools for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine.

Almost every commit is self-contained, so let me know if I should split them into separate PRs.

try-job: dist-aarch64-windows-gnullvm
try-job: dist-x86_64-windows-gnullvm

rustbot · 2025-05-07T21:22:37Z

r? @marcoieni

rustbot has assigned @marcoieni.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

rustbot · 2025-05-07T21:22:39Z

This PR changes how LLVM is built. Consider updating src/bootstrap/download-ci-llvm-stamp.

mati865 · 2025-05-11T21:12:03Z

Forgot to include try-job. Fixed it.

marcoieni · 2025-05-15T09:39:36Z

This will require MCP, but I suppose we need to know how long it takes to build first.

ok, so I guess we need to try this, right?

@bors try

{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-windows-gnullvm

bors · 2025-05-15T09:45:16Z

⌛ Trying commit d0b81ca with merge 9772d67...

marcoieni · 2025-05-15T13:54:32Z

maybe you need to add the job to the src/ci/github-actions/jobs.yml file?

bors · 2025-05-15T15:45:16Z

💥 Test timed out

mati865 · 2025-05-15T19:29:31Z

Oh, right. Totally forgot about it.

marcoieni · 2025-05-16T09:27:44Z

@bors try

bors · 2025-05-16T09:29:10Z

⌛ Trying commit b256449 with merge 34c404a...

{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-windows-gnullvm

bors · 2025-05-16T15:09:11Z

💔 Test failed - checks-actions

mati865 · 2025-05-16T16:24:42Z

System.IO.IOException: No space left on device

Unfortunately, free CI runners are not as capable as I had hoped. I've split the jobs now, but dunno if this will be acceptable.

marcoieni · 2025-05-19T14:41:01Z

I've split the jobs now, but dunno if this will be acceptable.

yes, we prefer multiple free runner compared to 1 large runner 👍

@bors try

{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-aarch64-windows-gnullvm try-job: dist-x86_64-windows-gnullvm

bors · 2025-05-19T14:42:14Z

⌛ Trying commit a84e84e with merge 9e708f5...

bors · 2025-05-19T14:49:16Z

💔 Test failed - checks-actions

marcoieni · 2025-05-19T15:41:57Z

@bors try

bors · 2025-05-19T15:51:39Z

💔 Test failed - checks-actions

mati865 · 2025-05-19T17:22:21Z

Sorry, hoped that I can avoid another local run, but I made too many mistakes when splitting. It's fixed now.

marcoieni · 2025-05-19T18:32:24Z

No worries!

@bors try

{aarch64,x86_64}-*-windows-gnullvm: build host tools This will require MCP, but I suppose we need to know how long it takes to build first. I opted for bootstrapping from Linux because that's the easiest host system to work with, but once this hits beta, having dedicated Windows runners would be sensible and probably preferable. `--enable-full-tools` for whatever reason doesn't seem to work when cross-compiling, because LLVM tools for the new hosts are not copied into the expected directory. And WiX that bootstrap relies upon to create .msi installers only supports Windows. I haven't tried, but it might be usable via Wine. Almost every commit is self-contained, so let me know if I should split them into separate PRs. try-job: dist-aarch64-windows-gnullvm try-job: dist-x86_64-windows-gnullvm

bors · 2025-05-19T18:33:36Z

⌛ Trying commit e2f8e7f with merge 98bb621...

bors · 2025-05-19T20:34:32Z

☀️ Try build successful - checks-actions
Build commit: 98bb621 (98bb6215bc277dce97b5d4e1f271444dbbea04f0)

marcoieni · 2025-05-20T08:24:45Z

timings look good 👍

so I guess this requires a MCP as you said in your first post, right? So I won't approve this PR yet.

…ndows This obviously doesn't work when cross-compiling from Linux.

mati865 · 2025-05-20T19:56:35Z

Thanks, I suppose the times will be even shorter with warm sccache.

@rustbot author

rustbot · 2025-05-20T19:56:37Z

Reminder, once the PR becomes ready for a review, use @rustbot ready.

WIX toolset works only on Windows hosts.

… tools

…ndows This obviously doesn't work when cross-compiling from Linux. Split out from: rust-lang#140772

…, r=jieyouxu Fixes for building windows-gnullvm hosts Split out from: rust-lang#140772

Rollup merge of #141819 - mati865:windows-gnullvm-host-fixes, r=jieyouxu Fixes for building windows-gnullvm hosts Split out from: #140772

rustbot assigned marcoieni May 7, 2025

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 16, 2025

This comment has been minimized.

Sign in to view

mati865 added 3 commits May 20, 2025 19:56

rustc_llvm: add Windows system libs only when cross-compiling from Wi…

c0e6035

…ndows This obviously doesn't work when cross-compiling from Linux.

Fix incorrect comment

9968c34

Fix C++ standard library name for *-windows-gnullvm targets

2d2d831

mati865 marked this pull request as draft May 20, 2025 19:56

mati865 mentioned this pull request May 23, 2025

Promote 64-bit windows-gnullvm Targets to Tier 2 with Host Tools rust-lang/compiler-team#877

Open

mati865 added 7 commits May 31, 2025 15:50

Don't create .msi installer when not building from Windows

b0dde9f

WIX toolset works only on Windows hosts.

Shared libLLVM linking is officially supported with MinGW and Clang

8c5560f

Move *-windows-gnullvm targets to it's own Dockerfile and enable host…

55cf782

… tools

Add CI job

f067953

Split CI into two jobs

bb26d88

fix paths after the split

d8012d4

Fix install script for AArch64

8ba75d1

mati865 force-pushed the gnullvm-host branch from e2f8e7f to 8ba75d1 Compare May 31, 2025 14:12

rustbot added the A-LLVM Area: Code generation parts specific to LLVM. Both correctness bugs and optimization-related issues. label May 31, 2025

mati865 added a commit to mati865/rust that referenced this pull request May 31, 2025

rustc_llvm: add Windows system libs only when cross-compiling from Wi…

81f61ac

…ndows This obviously doesn't work when cross-compiling from Linux. Split out from: rust-lang#140772

This was referenced May 31, 2025

rustc_llvm: add Windows system libs only when cross-compiling from Wi… #141817

Open

Don't create .msi installer when not building from Windows #141818

Open

Fixes for building windows-gnullvm hosts #141819

Merged

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 31, 2025

Rollup merge of rust-lang#141819 - mati865:windows-gnullvm-host-fixes…

23cc24e

…, r=jieyouxu Fixes for building windows-gnullvm hosts Split out from: rust-lang#140772

rust-timer added a commit that referenced this pull request May 31, 2025

Unrolled build for #141819

8944adc

Rollup merge of #141819 - mati865:windows-gnullvm-host-fixes, r=jieyouxu Fixes for building windows-gnullvm hosts Split out from: #140772

{aarch64,x86_64}-*-windows-gnullvm: build host tools #140772

Are you sure you want to change the base?

{aarch64,x86_64}-*-windows-gnullvm: build host tools #140772

Uh oh!

Conversation

mati865 commented May 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rustbot commented May 7, 2025

Uh oh!

rustbot commented May 7, 2025

Uh oh!

mati865 commented May 11, 2025

Uh oh!

marcoieni commented May 15, 2025

Uh oh!

bors commented May 15, 2025

Uh oh!

This comment has been minimized.

marcoieni commented May 15, 2025

Uh oh!

bors commented May 15, 2025

Uh oh!

mati865 commented May 15, 2025

Uh oh!

marcoieni commented May 16, 2025

Uh oh!

bors commented May 16, 2025

Uh oh!

This comment has been minimized.

bors commented May 16, 2025

Uh oh!

mati865 commented May 16, 2025

Uh oh!

marcoieni commented May 19, 2025

Uh oh!

bors commented May 19, 2025

Uh oh!

This comment has been minimized.

bors commented May 19, 2025

Uh oh!

marcoieni commented May 19, 2025

Uh oh!

This comment has been minimized.

bors commented May 19, 2025

Uh oh!

mati865 commented May 19, 2025

Uh oh!

marcoieni commented May 19, 2025

Uh oh!

bors commented May 19, 2025

Uh oh!

bors commented May 19, 2025

Uh oh!

marcoieni commented May 20, 2025

Uh oh!

mati865 commented May 20, 2025

Uh oh!

rustbot commented May 20, 2025

Uh oh!

Uh oh!

mati865 commented May 7, 2025 •

edited

Loading