Merged
Conversation
rustbot
added
A-attributes
Collaborator
|
HIR ty lowering was modified cc @fmease Some changes occurred in src/tools/clippy cc @rust-lang/clippy Some changes occurred in compiler/rustc_passes/src/check_attr.rs |
Specifically `TyAlias`, `Enum`, `Struct`, `Union`. So the fields match the textual order in the source code. The interesting part of the change is in `compiler/rustc_hir/src/hir.rs`. The rest is extremely mechanical refactoring.
In `Fn`, put `ident` next to `generics` as is common in many other types. In `print_fn`, make the argument order match the printing order.
nnethercote
force-pushed
the
hir-ItemKind-field-order
branch
from
976e31b to
aa3009d
Compare
Collaborator
|
A job failed! Check out the build log: (web) (plain) Click to see the possible cause of the failure (guessed by this bot) |
fee1-dead
approved these changes
May 31, 2025
Member
fee1-dead
left a comment
fee1-dead
left a comment
There was a problem hiding this comment.
I kinda wonder why these enum variants can't use struct style instead of tuple style. But that is separate from this PR.
Member
|
@bors r+ rollup |
Collaborator
bors
added
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
May 31, 2025
Rollup of 8 pull requests Successful merges: - #140787 (Note expr being cast when encounter NonScalar cast error) - #141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods) - #141646 (Document what `distcheck` is intended to exercise) - #141740 (Hir item kind field order) - #141793 (`tests/ui`: A New Order [1/N]) - #141805 (Update `compiler-builtins` to 0.1.160) - #141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows) - #141819 (Fixes for building windows-gnullvm hosts) r? `@ghost` `@rustbot` modify labels: rollup
Contributor
Author
I tried doing that with the AST in #141675 and it wasn't an improvement. Lots of |
github-actions bot
pushed a commit
to model-checking/verify-rust-std
that referenced
this pull request
Jun 3, 2025
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#140787 (Note expr being cast when encounter NonScalar cast error) - rust-lang#141112 (std: note that `std::str::from_utf8*` functions are aliases to `<str>::from_utf8*` methods) - rust-lang#141646 (Document what `distcheck` is intended to exercise) - rust-lang#141740 (Hir item kind field order) - rust-lang#141793 (`tests/ui`: A New Order [1/N]) - rust-lang#141805 (Update `compiler-builtins` to 0.1.160) - rust-lang#141815 (Enable non-leaf Frame Pointers for mingw-w64 Arm64 Windows) - rust-lang#141819 (Fixes for building windows-gnullvm hosts) r? `@ghost` `@rustbot` modify labels: rollup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A follow-up to #141675.
r? @fee1-dead