-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make --verbose imply -Z write-long-types-to-disk=no #121328
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When shortening the type it is necessary to take into account the `--verbose` flag, if it is activated, we must always show the entire type and not write it in a file. Fixes: rust-lang#119130
rustbot has assigned @compiler-errors. Use r? to explicitly pick a reviewer |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
labels
Feb 20, 2024
ffmancera
force-pushed
the
ff/verbose_long_type
branch
from
February 20, 2024 15:36
11d236d
to
e2413d7
Compare
ffmancera
force-pushed
the
ff/verbose_long_type
branch
from
February 20, 2024 22:34
e2413d7
to
6b72095
Compare
ffmancera
force-pushed
the
ff/verbose_long_type
branch
from
February 20, 2024 22:52
6b72095
to
e35481f
Compare
compiler-errors
approved these changes
Feb 20, 2024
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 20, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Rollup of 7 pull requests Successful merges: - rust-lang#121208 (Convert `delayed_bug`s to `bug`s.) - rust-lang#121288 (make rustc_expand translatable) - rust-lang#121304 (Add docs for extension proc-macro) - rust-lang#121328 (Make --verbose imply -Z write-long-types-to-disk=no) - rust-lang#121338 (Downgrade ambiguous_wide_pointer_comparisons suggestions to MaybeIncorrect) - rust-lang#121361 (diagnostic items for legacy numeric modules) - rust-lang#121375 (Print proper relative path for descriptive name check) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 21, 2024
Rollup merge of rust-lang#121328 - ffmancera:ff/verbose_long_type, r=compiler-errors Make --verbose imply -Z write-long-types-to-disk=no When shortening the type it is necessary to take into account the `--verbose` flag, if it is activated, we must always show the entire type and not write it in a file. Fixes: rust-lang#119130
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shortening the type it is necessary to take into account the
--verbose
flag, if it is activated, we must always show the entire type and not write it in a file.Fixes: #119130