Skip to content

Make --verbose imply -Z write-long-types-to-disk=no #121328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 21, 2024
Merged

Make --verbose imply -Z write-long-types-to-disk=no #121328

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e54ef0a
Make --verbose imply -Z write-long-types-to-disk=no
ffmancera Feb 20, 2024
e35481f
Suggest using --verbose when writing type to a file
ffmancera Feb 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Make --verbose imply -Z write-long-types-to-disk=no 
When shortening the type it is necessary to take into account the
`--verbose` flag, if it is activated, we must always show the entire
type and not write it in a file.

Fixes: #119130
  • Loading branch information
@ffmancera
ffmancera committed Feb 20, 2024
commit e54ef0a7ab42f6af8804632b1b5858c606fe1c3c
2 changes: 1 addition & 1 deletion compiler/rustc_middle/src/ty/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,7 +351,7 @@ impl<'tcx> TyCtxt<'tcx> {
})
.expect("could not write to `String`");

if !self.sess.opts.unstable_opts.write_long_types_to_disk {
if !self.sess.opts.unstable_opts.write_long_types_to_disk || self.sess.opts.verbose {
return regular;
}

Expand Down