-
Notifications
You must be signed in to change notification settings - Fork 340
Fix French translation. #659
Fix French translation. #659
Conversation
Update community.md
16.12.29.12.43
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
For further background, here is the original discussion on using the full IETF language tags for locale names. |
Fixes #666
fixed layout in chinese pages fixed date style in chinese and korean pages
fixed Chinese pages
Spanish translation
fix(font): use Mozilla version of font to fix bugs associated with Fira Font
Add 360dialog
Update onesignal blog
Update french translation of install.html
Add SmartThings to friends page
Specify correct logo email in _data/users.yml
Add translate Vietnam
Partially translate new Install page
@AndrewBrinker 👍 , would you mind rebasing this? |
Fix minor nitpick in the FAQ
Add translate Japanese
Spanish translation (continuation)
Okay, I did not do that correctly. Just a minute. Also, it looks like the Spanish translation now has the same problem as the French translation. If we're going to use the full language codes, we shouldn't accept PRs that don't. |
This is a good call; we shouldn't, and I should pay attention to that when reviewing. Thanks. |
I'm going to close this. I've opened #682 which addresses the |
Side note: thanks for taking translations so seriously! 😄 |
This commit basically reverts the locale name change done in #561. The pattern with other locales has been to use the longer-form IETF language tag for a given language (i.e. "en-US" vs. "en"). This leaves the door open for translations in non-majority dialects, and is generally more future-friendly. The reasoning given for moving from "fr-FR" to "fr" was that the change is consistent with Mozilla policy, but I think that the more important consistency is consistency with the rest of the Rust site.