Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Fix French translation. #659

Closed
wants to merge 48 commits into from
Closed

Fix French translation. #659

wants to merge 48 commits into from

Conversation

alilleybrinker
Copy link
Contributor

This commit basically reverts the locale name change done in #561. The pattern with other locales has been to use the longer-form IETF language tag for a given language (i.e. "en-US" vs. "en"). This leaves the door open for translations in non-majority dialects, and is generally more future-friendly. The reasoning given for moving from "fr-FR" to "fr" was that the change is consistent with Mozilla policy, but I think that the more important consistency is consistency with the rest of the Rust site.

@rust-highfive
Copy link

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alilleybrinker
Copy link
Contributor Author

For further background, here is the original discussion on using the full IETF language tags for locale names.

3442853561 and others added 9 commits December 31, 2016 22:08
Translated the latest version of the index page
A number of recommendations were received from native speakers
fixed layout in chinese pages
fixed date style in chinese and korean pages
fix(font): use Mozilla version of font to fix bugs associated with Fira Font
@steveklabnik
Copy link
Member

@AndrewBrinker 👍 , would you mind rebasing this?

@alilleybrinker
Copy link
Contributor Author

Okay, I did not do that correctly. Just a minute.

Also, it looks like the Spanish translation now has the same problem as the French translation. If we're going to use the full language codes, we shouldn't accept PRs that don't.

@steveklabnik
Copy link
Member

If we're going to use the full language codes, we shouldn't accept PRs that don't.

This is a good call; we shouldn't, and I should pay attention to that when reviewing. Thanks.

@alilleybrinker
Copy link
Contributor Author

I'm going to close this. I've opened #682 which addresses the fr and es language codes.

@alilleybrinker
Copy link
Contributor Author

Side note: thanks for taking translations so seriously! 😄

@alilleybrinker alilleybrinker deleted the fix-french-translation branch August 1, 2017 22:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.