This repository was archived by the owner on Sep 30, 2020. It is now read-only.
fix(font): use Mozilla version of font to fix bugs associated with Fira Font #665
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
Removing the local versions seems fine for the website, but the equal fix in rustdoc would want the local files, I'd imagine. |
|
ok i just added the local files. all come from here, fyi https://github.com/mozilla/Fira/blob/master/fira.css |
ashleygwilliams
changed the title
|
@bors r+ |
|
Er |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #658
pointing styles at the mozilla cdn for Fira Sans font fixes all display issues. replacing the woff files that were included with the ones from the mozilla cdn didn't. so i assume that there are different formats being used to fix the bug here.
could probably pull everything in locally if we wanted, but it'd be bigger than what ya'll had before. lemme know if you'd like it local.