Skip to content
This repository was archived by the owner on Sep 30, 2020. It is now read-only.

Spanish translation #651

Merged
merged 3 commits into from
Jan 3, 2017
Merged

Spanish translation #651

merged 3 commits into from
Jan 3, 2017

Conversation

alx741
Copy link
Contributor

@alx741 alx741 commented Dec 22, 2016

So I started the Spanish translation here, but wanted to be sure I'm doing it correctly before proceeding with the rest of it.

I noticed the convention is lang-2-letter-country-code, but there is also french named just fr and the Spanish translation also fits best just as es (is that ok?)

@rust-highfive
Copy link

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@brson brson self-assigned this Dec 22, 2016
@brson
Copy link
Contributor

brson commented Dec 22, 2016

Thanks @alx741 ! It looks good to me.

Why is plain 'es' appropriate? I don't recall why 'fr' is used instead of something more specific. Maybe because there's overwhelmingly one type of French? @steveklabnik probably remembers.

@alx741
Copy link
Contributor Author

alx741 commented Dec 22, 2016

I now nothing about the best practices about this i18n naming, but I thought es fits better because I'm using Spanish that complies with Real Academia Española and no linguistic regionalisms whatsoever, so making es-EC (for Ecuador) would imply the possibility of adding es-AR, es-ES, es-CO, es-MX, and a dozen more with no differences between each other.

@brson brson merged commit 860b891 into rust-lang:master Jan 3, 2017
@brson
Copy link
Contributor

brson commented Jan 3, 2017

Thanks @alx741 !

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants