progressive linking #564
Merged
progressive linking #564
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/lib.rs
Outdated
|
|
||
| for chunk in objs.chunks(chunk_size) { |
There was a problem hiding this comment.
Instead of calculating chunk_size could we perhaps conservatively just say the chunk size is 100? That seems like it would probably cover almost all use cases I think?
|
👍 |
Closed
alexcrichton
added a commit
that referenced
this pull request
Nov 20, 2020
The `r` option means "add the object while replacing it if it already exists", while the `q` option says "always add to the end". We actually want the latter of these due to how this crate works because we're always building archives from scratch, and we always want all our objects to go in the archive instead of trying to replace previous versions. This should fix a recent issue with #564 where previously if everything was in one giant command line `ar` would append two files but now afterwards with multiple invocations the second invocation may overwrite files added in the first invocation. Closes #568
alexcrichton
added a commit
that referenced
this pull request
Nov 20, 2020
The `r` option means "add the object while replacing it if it already exists", while the `q` option says "always add to the end". We actually want the latter of these due to how this crate works because we're always building archives from scratch, and we always want all our objects to go in the archive instead of trying to replace previous versions. This should fix a recent issue with #564 where previously if everything was in one giant command line `ar` would append two files but now afterwards with multiple invocations the second invocation may overwrite files added in the first invocation. Closes #568
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fix both #547 and #496
msvc, linking is split into chunks based on the estimated command line length and the number of objects that need linking. If the estimated command line length doesn't exceed1024 * 6it will process all files in one go like before.msvchosts, nothing has changed as the objects are not split into chunks.All tests succeeded locally and as an additional test I've compiled the huge
physxcrate frommsvcto bothmsvcand Android.