Skip to content

Fix "Argument list too long" when building with windows-gnu target #496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

chaoticlonghair
Copy link

When building rust-rocksdb with target x86_64-pc-windows-gnu (mingw-w64-x86_64-rust in msys2), the compiler throw the error ar: Argument list too long.

@alexcrichton
Copy link
Member

Thanks for the PR! Would it be possible to perhaps take a different strategy though? I think we can call the ar command multiple times (although maybe with a different set of flags) to incrementally add objects to an archive. I think that may be a bit easier than trying to lump it all into one go?

@chaoticlonghair
Copy link
Author

call the ar command multiple times

OK, I will try this.

@VZout
Copy link

VZout commented Aug 19, 2020

I'm running into this issue as well. @alexcrichton could you elaborate on your feedback?

As I understand it cc-rs supports response files for the msvc target but no other targets. This PR adds that.
Do you want to "redesign/move" how response files are handled in general?

Minor side note: https://github.com/alexcrichton/cc-rs/pull/496/files#diff-b4aea3e418ccdb71239b96952d9cddb6R1705
Should be host not target to support cross compiling.

@alexcrichton
Copy link
Member

I don't think it's necessary to use response files here, I think we can call the archiver multiple times to add objects, which should simplify this PR

@VZout VZout mentioned this pull request Aug 24, 2020
@maxded maxded mentioned this pull request Nov 17, 2020
@thomcc thomcc added the O-windows Windows targets and toolchains label Oct 26, 2022
@NobodyXu
Copy link
Collaborator

#564 should have already fixed this issue, closing this PR

@NobodyXu NobodyXu closed this Feb 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-windows Windows targets and toolchains
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants