Switch from the r option on ar to q
#569
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `r` option means "add the object while replacing it if it already exists", while the `q` option says "always add to the end". We actually want the latter of these due to how this crate works because we're always building archives from scratch, and we always want all our objects to go in the archive instead of trying to replace previous versions. This should fix a recent issue with #564 where previously if everything was in one giant command line `ar` would append two files but now afterwards with multiple invocations the second invocation may overwrite files added in the first invocation. Closes #568
alexcrichton
added a commit
that referenced
this pull request
Nov 20, 2020
This commit splits out the `s` command from the `ar` invocation to happen as part of a separate step after the archive is fully assembled. Turns out #569 has an issue on Linux where `qs` implies `r` (??), so to get the append-only behavior of `q` we need to omit the `s`. Closes #568 (for real this time?)
alexcrichton
added a commit
that referenced
this pull request
Nov 20, 2020
This commit splits out the `s` command from the `ar` invocation to happen as part of a separate step after the archive is fully assembled. Turns out #569 has an issue on Linux where `qs` implies `r` (??), so to get the append-only behavior of `q` we need to omit the `s`. Closes #568 (for real this time?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
roption means "add the object while replacing it if it alreadyexists", while the
qoption says "always add to the end". We actuallywant the latter of these due to how this crate works because we're
always building archives from scratch, and we always want all our
objects to go in the archive instead of trying to replace previous
versions.
This should fix a recent issue with #564 where previously if everything
was in one giant command line
arwould append two files but nowafterwards with multiple invocations the second invocation may overwrite
files added in the first invocation.
Closes #568