Skip to content

fix bug in #537 #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2021
Merged

fix bug in #537 #549

merged 1 commit into from
Nov 9, 2021

Conversation

burrbull
Copy link
Member

@burrbull burrbull commented Nov 9, 2021 •
edited by Emilgardis
Loading

resolves #547

@burrbull burrbull requested a review from a team as a code owner November 9, 2021 14:46
@rust-highfive
Copy link

r? @adamgreig

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools labels Nov 9, 2021
@burrbull burrbull mentioned this pull request Nov 9, 2021
Closed
Emilgardis
Emilgardis requested changes Nov 9, 2021
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change commit to mention correct issue

Emilgardis
Emilgardis approved these changes Nov 9, 2021
View reviewed changes
Copy link
Member

@Emilgardis Emilgardis left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was more leaning towards the commit message, but it's fine. I linked the issue where this was found.

Leaving r=me for you if there's maybe something else

@burrbull
Copy link
Member Author

burrbull commented Nov 9, 2021

bors r=Emilgardis

@bors
Copy link
Contributor

bors bot commented Nov 9, 2021

Build succeeded:

@bors bors bot merged commit 43be074 into master Nov 9, 2021
@bors bors bot deleted the fix_537 branch November 9, 2021 15:36
robamu added a commit to robamu-org/va108xx-rs that referenced this pull request Nov 9, 2021
@robamu
Important fix: Use bitmask everywhere now
26f0c80 
This PAC was generated using a patched version of svd2rust with
commit hash 43be074d21132c3a76780816010df592a3603874

It includes bugfix rust-embedded/svd2rust#549
robamu added a commit to robamu-org/va108xx-rs that referenced this pull request Nov 9, 2021
@robamu
Important fix: Use bitmask everywhere now
8c28367 
This PAC was generated using a patched version of svd2rust with
commit hash 43be074d21132c3a76780816010df592a3603874

It includes bugfix rust-embedded/svd2rust#549
@robamu robamu mentioned this pull request Nov 9, 2021
Merged
bors bot added a commit to robamu-org/va108xx-rs that referenced this pull request Nov 9, 2021
@bors @robamu
Merge #11
1f6b133 
11: Update to v0.1.1 with important bugfix r=robamu a=robamu

This PAC was generated using a patched version of svd2rust with
commit hash 43be074d21132c3a76780816010df592a3603874

It includes bugfix rust-embedded/svd2rust#549

Co-authored-by: Robin Mueller <robin.mueller.m@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Emilgardis Emilgardis Emilgardis approved these changes

Assignees

@adamgreig adamgreig

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reader for bit range [0:0] incorrect
4 participants
@burrbull @rust-highfive @Emilgardis @adamgreig