Don't use a mask when not needed #537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Emilgardis (or someone else) soon. Please see the contribution instructions for more information. |
rust-highfive
added
S-waiting-on-review
Emilgardis
reviewed
Aug 20, 2021
burrbull
previously approved these changes
Aug 20, 2021
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 20, 2021
537: Don't use a mask when not needed r=burrbull a=thibautvdv When the mask has the same size as the parent register of a field, then a mask is not required. This removes the clippy warnings/errors where for example an operation of inverting a mask results in zero ``` error: this operation will always return zero. This is likely not the intended outcome | 61 | self.w.bits = (self.w.bits & !0xffff_ffff) | (value as u32 & 0xffff_ffff); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ``` or when the operation of using a mask is ineffective. ``` warning: the operation is ineffective. Consider reducing it to `value as u32` | 61 | self.w.bits = (self.w.bits & !0xffff_ffff) | (value as u32 & 0xffff_ffff); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ``` Co-authored-by: Thibaut Vandervelden <thvdveld@vub.be>
|
bors r- |
|
Canceled. |
burrbull
reviewed
Aug 20, 2021
|
Squash commits, please. |
When the mask has the same size as the parent register of a field, then a mask is not required. This removes the clippy warnings/errors where for example an operation of inverting a mask results in zero ``` error: this operation will always return zero. This is likely not the intended outcome | 61 | self.w.bits = (self.w.bits & !0xffff_ffff) | (value as u32 & 0xffff_ffff); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ``` or when the operation of using a mask is ineffective. ``` warning: the operation is ineffective. Consider reducing it to `value as u32` | 61 | self.w.bits = (self.w.bits & !0xffff_ffff) | (value as u32 & 0xffff_ffff); | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ | ```
thvdveld
force-pushed
the
dont_use_mask
branch
from
df25f3a to
c2ca27f
Compare
burrbull
approved these changes
Aug 20, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the mask has the same size as the parent register of a field, then
a mask is not required. This removes the clippy warnings/errors where
for example an operation of inverting a mask results in zero
or when the operation of using a mask is ineffective.