Skip to content

Gemspec cleanup #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2014
Merged

Gemspec cleanup #146

merged 4 commits into from
Oct 24, 2014

Conversation

jch
Copy link
Member

@jch jch commented Oct 24, 2014

I audited the fields used in the gemspec and updated things according to the current gemspec reference: http://guides.rubygems.org/specification-reference/

Comments inline.

@@ -7,8 +7,6 @@ Gem::Specification.new do |s|
s.name = %q{net-ldap}
s.version = Net::LDAP::VERSION
s.license = "MIT"

s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't filter anything, so I removed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jch jch mentioned this pull request Oct 24, 2014
@mtodd
Copy link
Member

mtodd commented Oct 24, 2014

Looks good. Did you try building the gem? Have any issues with it?

@jch
Copy link
Member Author

jch commented Oct 24, 2014

@mtodd works fine with my setup:

$ gem --version
2.0.14

$ ruby --version
ruby 2.0.0p481 (2014-05-08 revision 45883) [x86_64-darwin13.2.0]

$ gem build net-ldap.gemspec 
  Successfully built RubyGem
  Name: net-ldap
  Version: 0.8.0
  File: net-ldap-0.8.0.gem

@mtodd
Copy link
Member

mtodd commented Oct 24, 2014

@jch I'd probably also install it just to make sure it's a sanely built
package, but that's probably just my paranoia. Nothing in here is drastic.

On Fri, Oct 24, 2014 at 1:30 PM, Jerry Cheung notifications@github.com
wrote:

@mtodd https://github.com/mtodd works fine with my setup:

$ gem --version
2.0.14

$ ruby --version
ruby 2.0.0p481 (2014-05-08 revision 45883) [x86_64-darwin13.2.0]

$ gem build net-ldap.gemspec
Successfully built RubyGem
Name: net-ldap
Version: 0.8.0
File: net-ldap-0.8.0.gem


Reply to this email directly or view it on GitHub
#146 (comment)
.

Matt Todd
GitHub, Inc
www.github.com
cell: 404-314-2612
blog: maraby.org

@jch
Copy link
Member Author

jch commented Oct 24, 2014

Good call, can't be too sure with changes like these. Verified the build gem works as well:

$ gem install projects/ruby-net-ldap/net-ldap-0.8.0.gem 
Successfully installed net-ldap-0.8.0
1 gem installed
jch@cupcake:~$ irb
irb(main):001:0> require 'net/ldap'
=> true
irb(main):002:0> puts $:
/opt/rubies/2.0.0-p481/lib/ruby/gems/2.0.0/gems/net-ldap-0.8.0/lib  # ensure it's the gem I installed
ldap = Net::LDAP.new(...)
ldap.bind
=> true

@mtodd
Copy link
Member

mtodd commented Oct 24, 2014

😎 awesome. :shipit:

On Fri, Oct 24, 2014 at 2:37 PM, Jerry Cheung notifications@github.com
wrote:

Good call, can't be too sure with changes like these. Verified the build
gem works as well:

$ gem install projects/ruby-net-ldap/net-ldap-0.8.0.gem
Successfully installed net-ldap-0.8.0
1 gem installed
jch@cupcake:~$ irb
irb(main):001:0> require 'net/ldap'
=> true
irb(main):002:0> puts $:
/opt/rubies/2.0.0-p481/lib/ruby/gems/2.0.0/gems/net-ldap-0.8.0/lib # ensure it's the gem I installed
ldap = Net::LDAP.new(...)
ldap.bind
=> true


Reply to this email directly or view it on GitHub
#146 (comment)
.

Matt Todd
GitHub, Inc
www.github.com
cell: 404-314-2612
blog: maraby.org

jch added a commit that referenced this pull request Oct 24, 2014
@jch jch merged commit 0df44b0 into master Oct 24, 2014
@jch jch deleted the gemspec-cleanup branch October 24, 2014 21:52
astratto pushed a commit to astratto/ruby-net-ldap that referenced this pull request Dec 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants