-
Notifications
You must be signed in to change notification settings - Fork 252
Gemspec cleanup #146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Gemspec cleanup #146
Conversation
this will be set by the actual version that builds it http://guides.rubygems.org/specification-reference/#rubygemsversion
follows the spec reference defined in http://guides.rubygems.org/specification-reference/
@@ -7,8 +7,6 @@ Gem::Specification.new do |s| | |||
s.name = %q{net-ldap} | |||
s.version = Net::LDAP::VERSION | |||
s.license = "MIT" | |||
|
|||
s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version= |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't filter anything, so I removed it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Looks good. Did you try building the gem? Have any issues with it? |
@mtodd works fine with my setup: $ gem --version
2.0.14
$ ruby --version
ruby 2.0.0p481 (2014-05-08 revision 45883) [x86_64-darwin13.2.0]
$ gem build net-ldap.gemspec
Successfully built RubyGem
Name: net-ldap
Version: 0.8.0
File: net-ldap-0.8.0.gem |
@jch I'd probably also install it just to make sure it's a sanely built On Fri, Oct 24, 2014 at 1:30 PM, Jerry Cheung notifications@github.com
Matt Todd |
Good call, can't be too sure with changes like these. Verified the build gem works as well:
|
😎 awesome. On Fri, Oct 24, 2014 at 2:37 PM, Jerry Cheung notifications@github.com
Matt Todd |
Gemspec cleanup
I audited the fields used in the gemspec and updated things according to the current gemspec reference: http://guides.rubygems.org/specification-reference/
Comments inline.