Skip to content

Gemspec cleanup #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Oct 24, 2014
Merged

Gemspec cleanup #146

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
41b22f4
remove rubygems_version
Oct 24, 2014
c624306
requirement does not actually limit anything
Oct 24, 2014
be86fe9
use a string for required_ruby_version
Oct 24, 2014
9526493
simplify how development dependencies are declared
Oct 24, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 5 additions & 24 deletions net-ldap.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,8 +7,6 @@ Gem::Specification.new do |s|
s.name = %q{net-ldap}
s.version = Net::LDAP::VERSION
s.license = "MIT"

s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
s.authors = ["Francis Cianfrocca", "Emiel van de Laar", "Rory O'Connell", "Kaspar Schiess", "Austin Ziegler", "Michael Schaarschmidt"]
s.date = %q{2012-02-28}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't filter anything, so I removed it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

s.description = %q{Net::LDAP for Ruby (also called net-ldap) implements client access for the
Expand All @@ -29,28 +27,11 @@ the most recent LDAP RFCs (4510-4519, plutions of 4520-4532).}
s.homepage = %q{http://github.com/ruby-ldap/ruby-net-ldap}
s.rdoc_options = ["--main", "README.rdoc"]
s.require_paths = ["lib"]
s.required_ruby_version = Gem::Requirement.new(">= 1.9.3")
s.rubygems_version = %q{1.5.2}
s.required_ruby_version = ">= 1.9.3"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed to a string here because that's what's recommended by the reference.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect.

s.summary = %q{Net::LDAP for Ruby (also called net-ldap) implements client access for the Lightweight Directory Access Protocol (LDAP), an IETF standard protocol for accessing distributed directory services}

if s.respond_to? :specification_version then
s.specification_version = 3

if Gem::Version.new(Gem::VERSION) >= Gem::Version.new('1.2.0') then
s.add_development_dependency(%q<hoe-git>, ["~> 1"])
s.add_development_dependency(%q<hoe-gemspec>, ["~> 1"])
s.add_development_dependency(%q<flexmock>, [">= 1.3.0"])
s.add_development_dependency(%q<hoe>, [">= 2.9.1"])
else
s.add_dependency(%q<hoe-git>, ["~> 1"])
s.add_dependency(%q<hoe-gemspec>, ["~> 1"])
s.add_dependency(%q<flexmock>, [">= 1.3.0"])
s.add_dependency(%q<hoe>, [">= 2.9.1"])
end
else
s.add_dependency(%q<hoe-git>, ["~> 1"])
s.add_dependency(%q<hoe-gemspec>, ["~> 1"])
s.add_dependency(%q<flexmock>, [">= 1.3.0"])
s.add_dependency(%q<hoe>, [">= 2.9.1"])
end
s.add_development_dependency("hoe-git", "~> 1")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be set by the rubygem that builds the gem, not here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔥 it down. :)

s.add_development_dependency("hoe-gemspec", "~> 1")
s.add_development_dependency("flexmock", ">= 1.3.0")
s.add_development_dependency("hoe", ">= 2.9.1")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubygems 1.2.0 was released in 2008-06-21, past the EOL for rubies we're supporting.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call.

end