Conversation
- Allow "latex" attribute (as alternative to "data-latex"). Note that the "data-" prefix is an HTML convention and Pandoc already automatically adds a "data-" prefix to HTML attributes it doesn't recognize. Net: for markdown syntax like this we don't need to use "data-" prefixes. - Allow slightly more intuitive syntax for a latex div with no options: `latex=true` or `latex=1` - If the leading and trailing blocks in the div are paragraphs than write the environment begin/end flush up to the block text (the extra lines added when inserting raw blocks can make a difference for some environment implementations)
cderv
approved these changes
Dec 18, 2020
Collaborator
cderv
left a comment
cderv
left a comment
There was a problem hiding this comment.
Looks great, thank you ! latex=true or latex=1 is indeed more intuitive.
We just need to add a NEWS bullet and bump the version before merging.
This was referenced Dec 18, 2020
Member
Author
|
Okay, done! |
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Jan 25, 2021
Merge branch 'master' of https://github.com/rstudio/rmarkdown * 'master' of https://github.com/rstudio/rmarkdown: (111 commits) get rid of names, otherwise the returned vector will have names like this: Only run testrmd if pandoc is available Warn that cropping is disabled if pdfcrop or ghostscript are not found. (rstudio#2017) Add shiny to remotes (rstudio#2014) file.path.ci is too loose with file matching (rstudio#2012) improve error messages for the new theme argument behavior Add Bootstrap 4 support (rstudio#1706) amend rstudio#1965: do not force `options(htmltools.preserve.raw = TRUE)` when this option has been set, otherwise it is impossible for other packages to turn this option off, e.g., yihui/xaringan#293 htmltools 0.5.1 is on CRAN now remove download stats use on.exit to remove file (rstudio#2001) use only the TinyTeX-1 version in CI (rstudio#1998) Cache should work on Windows with recent version of R (rstudio#1997) exclude renv folder from render_site() copied resources (rstudio#1996) Update CI to last Pandoc 2.11.3.1 (rstudio#1992) Revert "return div not nil for non-qualifying latex div" Add missing NEWS item for v2.6 release return div not nil for non-qualifying latex div Add `output_format_filter` function to `default_site_generator()`. (rstudio#1989) Improvements to latex-div (rstudio#1984) ... # Conflicts: # NEWS.md # R/render.R # man/render.Rd
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Jan 25, 2021
* master: (111 commits) get rid of names, otherwise the returned vector will have names like this: Only run testrmd if pandoc is available Warn that cropping is disabled if pdfcrop or ghostscript are not found. (rstudio#2017) Add shiny to remotes (rstudio#2014) file.path.ci is too loose with file matching (rstudio#2012) improve error messages for the new theme argument behavior Add Bootstrap 4 support (rstudio#1706) amend rstudio#1965: do not force `options(htmltools.preserve.raw = TRUE)` when this option has been set, otherwise it is impossible for other packages to turn this option off, e.g., yihui/xaringan#293 htmltools 0.5.1 is on CRAN now remove download stats use on.exit to remove file (rstudio#2001) use only the TinyTeX-1 version in CI (rstudio#1998) Cache should work on Windows with recent version of R (rstudio#1997) exclude renv folder from render_site() copied resources (rstudio#1996) Update CI to last Pandoc 2.11.3.1 (rstudio#1992) Revert "return div not nil for non-qualifying latex div" Add missing NEWS item for v2.6 release return div not nil for non-qualifying latex div Add `output_format_filter` function to `default_site_generator()`. (rstudio#1989) Improvements to latex-div (rstudio#1984) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allow "latex" attribute (as alternative to "data-latex"). Note that the "data-" prefix is an HTML convention and Pandoc already automatically adds a "data-" prefix to HTML attributes it doesn't recognize. Net: for markdown syntax like this we don't need to use "data-" prefixes.
Allow slightly more intuitive syntax for a latex div with no options:
latex=trueorlatex=1If the leading and trailing blocks in the div are paragraphs than write the environment begin/end flush up to the block text (the extra lines added when inserting raw blocks can make a difference for some environment implementations)