Warn that cropping is disabled if pdfcrop or ghostscript are not found.#2017
Merged
Warn that cropping is disabled if pdfcrop or ghostscript are not found.#2017
Conversation
3 tasks
yihui
approved these changes
Jan 21, 2021
Contributor
yihui
left a comment
yihui
left a comment
There was a problem hiding this comment.
The PR looks good enough to me. Thanks!
I'm not sure if the peculiarity of which on macOS is still there. Someday we might be able to get rid of the hack
Lines 293 to 309 in dbc4a68
I've been using Sys.which() myself and haven't run into this problem. My guess is that we originally had this hack mainly because of the nonstandard path of MacTeX (which is something like /usr/texbin). TinyTeX's binaries are symlinked to the standard /usr/local/bin so it won't suffer from this problem.
yihui
reviewed
Jan 21, 2021
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Jan 25, 2021
Merge branch 'master' of https://github.com/rstudio/rmarkdown * 'master' of https://github.com/rstudio/rmarkdown: (111 commits) get rid of names, otherwise the returned vector will have names like this: Only run testrmd if pandoc is available Warn that cropping is disabled if pdfcrop or ghostscript are not found. (rstudio#2017) Add shiny to remotes (rstudio#2014) file.path.ci is too loose with file matching (rstudio#2012) improve error messages for the new theme argument behavior Add Bootstrap 4 support (rstudio#1706) amend rstudio#1965: do not force `options(htmltools.preserve.raw = TRUE)` when this option has been set, otherwise it is impossible for other packages to turn this option off, e.g., yihui/xaringan#293 htmltools 0.5.1 is on CRAN now remove download stats use on.exit to remove file (rstudio#2001) use only the TinyTeX-1 version in CI (rstudio#1998) Cache should work on Windows with recent version of R (rstudio#1997) exclude renv folder from render_site() copied resources (rstudio#1996) Update CI to last Pandoc 2.11.3.1 (rstudio#1992) Revert "return div not nil for non-qualifying latex div" Add missing NEWS item for v2.6 release return div not nil for non-qualifying latex div Add `output_format_filter` function to `default_site_generator()`. (rstudio#1989) Improvements to latex-div (rstudio#1984) ... # Conflicts: # NEWS.md # R/render.R # man/render.Rd
jonathan-g
added a commit
to jonathan-g/rmarkdown
that referenced
this pull request
Jan 25, 2021
* master: (111 commits) get rid of names, otherwise the returned vector will have names like this: Only run testrmd if pandoc is available Warn that cropping is disabled if pdfcrop or ghostscript are not found. (rstudio#2017) Add shiny to remotes (rstudio#2014) file.path.ci is too loose with file matching (rstudio#2012) improve error messages for the new theme argument behavior Add Bootstrap 4 support (rstudio#1706) amend rstudio#1965: do not force `options(htmltools.preserve.raw = TRUE)` when this option has been set, otherwise it is impossible for other packages to turn this option off, e.g., yihui/xaringan#293 htmltools 0.5.1 is on CRAN now remove download stats use on.exit to remove file (rstudio#2001) use only the TinyTeX-1 version in CI (rstudio#1998) Cache should work on Windows with recent version of R (rstudio#1997) exclude renv folder from render_site() copied resources (rstudio#1996) Update CI to last Pandoc 2.11.3.1 (rstudio#1992) Revert "return div not nil for non-qualifying latex div" Add missing NEWS item for v2.6 release return div not nil for non-qualifying latex div Add `output_format_filter` function to `default_site_generator()`. (rstudio#1989) Improvements to latex-div (rstudio#1984) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
here is a proposal to do that on rmarkdown side.
It is oriented specifically toward cropping tools for which we want the warning. I had the idea to make it more generic but we don't need it for now so I stop myself from doing it.
Other solutions could be by adapting
find_program()so that it warns, or using (exporting ?)knitr:::has_utility()but the logic is not exactly the same asfind_program()(which deals with OSX a specific way). Opportunity to refactor ?Anyway, here is a PR to have you thoughts before merging.