Skip to content

Conversation

@SteveMacenski
Copy link
Member

Latest Kilted Sync on August 19, 2025

doisyg and others added 22 commits August 19, 2025 15:20
Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
* min_distance_to_obstacle

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* suggestion to time base and combine

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* typo

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* use min_approach_linear_velocity

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

---------

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Signed-off-by: Marco Bassa <marco.bassa@idealworks.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
)

Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
Signed-off-by: Silvio Traversaro <silvio@traversaro.it>
* Adding epsilon for voxel_layer precision loss

Signed-off-by: bhx <1273698633@qq.com>

* Update nav2_costmap_2d/plugins/voxel_layer.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_costmap_2d/plugins/voxel_layer.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

* Update nav2_costmap_2d/plugins/voxel_layer.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: bhx <1273698633@qq.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
…ry_help_condition (#5326)

The ThroughActionResult type alias was incorrectly referencing Action::Result 
instead of ThroughAction::Result, causing the condition to not work properly 
for ComputePathThroughPoses actions.

Fixes #5324

Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com>
* outputting tracker feedback on BT node

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* initializing outputs

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* outputting last state on success

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* linting

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* fixed nav2_tree_nodes.xml

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* Update nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/compute_and_track_route_action.hpp

Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: alexanderjyuen <103065090+alexanderjyuen@users.noreply.github.com>

* consolidated function to set outputs null, only setOutput with active feedback

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* add class to method

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

* linting

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>

---------

Signed-off-by: Alexander Yuen <alex@polymathrobotics.com>
Signed-off-by: alexanderjyuen <103065090+alexanderjyuen@users.noreply.github.com>
Co-authored-by: Steve Macenski <stevenmacenski@gmail.com>
* Adding slow down at target heading to RPP

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>

* Update test_regulated_pp.cpp

Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>

---------

Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: Steve Macenski <stevenmacenski@gmail.com>
Signed-off-by: Alberto Tudela <ajtudela@gmail.com>
* Add min obstacle height in voxel layer

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>

* Fix linting

Signed-off-by: Maurice <mauricepurnawan@gmail.com>

---------

Signed-off-by: mini-1235 <mauricepurnawan@gmail.com>
Signed-off-by: Maurice <mauricepurnawan@gmail.com>
Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
* [DEX] limit comparison precision

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

* EPSILON 1e-5

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>

---------

Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
Signed-off-by: Guillaume Doisy <guillaume@dexory.com>
Co-authored-by: Guillaume Doisy <guillaume@dexory.com>
…#5420)

* fix: Add KDTree type definition to include unsigned int for IndexType

Signed-off-by: Ericsii <ericfengx@foxmail.com>

* code format

Signed-off-by: Ericsii <ericfengx@foxmail.com>

---------

Signed-off-by: Ericsii <ericfengx@foxmail.com>
* Smooth path even if goal pose is so much near to the robot

Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com>

* Apply suggestions

Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com>

* Remove unnecessary diff

Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com>

---------

Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com>
Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
* Support loading multiple behavior tree files as subtrees

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* Fix code style

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* Added default param value

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* Added recursive check to loadBehaviorTree and adapted unit test accordingly

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* Removed nested loadBehaviorTree check in navigators

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* Removed whitespace cpplint

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* Fixed goalReceived

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* Let loadbehaviorTree use its own search_directories var

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* PR fixes-format-lint and test

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* fix pointer

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* Added unit test for BT xml validity

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* CPPLint

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* Check non existent search directory for bt

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* CPPLint

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* Fixed BT tests

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

* Fixed BT tests

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>

---------

Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai>
Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
@SteveMacenski SteveMacenski changed the base branch from main to kilted August 19, 2025 22:43
@ros-navigation ros-navigation deleted a comment from mergify bot Aug 19, 2025
Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
@SteveMacenski SteveMacenski changed the title Sync kilted Aug 19, 2025 Sync kilted Aug 19, 2025 1.4.1 Aug 19, 2025
Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
Signed-off-by: SteveMacenski <stevenmacenski@gmail.com>
@codecov
Copy link

codecov bot commented Aug 20, 2025

Codecov Report

❌ Patch coverage is 80.91603% with 25 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../plugins/action/compute_and_track_route_action.cpp 67.85% 9 Missing ⚠️
...clude/nav2_behavior_tree/bt_action_server_impl.hpp 66.66% 4 Missing ⚠️
..._pure_pursuit_controller/src/collision_checker.cpp 42.85% 4 Missing ⚠️
nav2_costmap_2d/plugins/voxel_layer.cpp 75.00% 3 Missing ⚠️
nav2_smac_planner/src/smac_planner_hybrid.cpp 82.35% 3 Missing ⚠️
...av2_docking/opennav_docking/src/docking_server.cpp 0.00% 1 Missing ⚠️
nav2_mppi_controller/src/optimizer.cpp 50.00% 1 Missing ⚠️
Files with missing lines Coverage Δ
...mcl/src/motion_model/differential_motion_model.cpp 100.00% <ø> (ø)
...nclude/nav2_behavior_tree/behavior_tree_engine.hpp 100.00% <ø> (ø)
...ee/include/nav2_behavior_tree/bt_action_server.hpp 83.33% <ø> (ø)
.../plugins/action/compute_and_track_route_action.hpp 100.00% <100.00%> (ø)
nav2_behavior_tree/src/behavior_tree_engine.cpp 83.87% <100.00%> (ø)
...avigator/src/navigators/navigate_through_poses.cpp 88.23% <ø> (ø)
...2_bt_navigator/src/navigators/navigate_to_pose.cpp 83.33% <ø> (ø)
...core/include/nav2_core/behavior_tree_navigator.hpp 89.65% <100.00%> (ø)
...ostmap_2d/include/nav2_costmap_2d/static_layer.hpp 100.00% <ø> (ø)
...tmap_2d/plugins/costmap_filters/costmap_filter.cpp 89.33% <100.00%> (ø)
... and 18 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@SteveMacenski SteveMacenski merged commit 47f84de into kilted Aug 20, 2025
12 of 13 checks passed
@SteveMacenski SteveMacenski deleted the sync_kilted branch August 20, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.