Fix KeepoutFilter on the ARM architecture #5436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
SteveMacenski
approved these changes
Aug 11, 2025
SteveMacenski
pushed a commit
that referenced
this pull request
Aug 19, 2025
Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
SteveMacenski
pushed a commit
that referenced
this pull request
Aug 19, 2025
Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
SteveMacenski
added a commit
that referenced
this pull request
Aug 20, 2025
* Conserve curvature with LIMIT action (#5255) * Conserve curvature with LIMIT action Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix format Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix test Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Adding epsilon for voxel_layer precision loss (#5314) * Adding epsilon for voxel_layer precision loss Signed-off-by: bhx <1273698633@qq.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: bhx <1273698633@qq.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * fix: correct ThroughActionResult type alias in would_a_planner_recovery_help_condition (#5326) The ThroughActionResult type alias was incorrectly referencing Action::Result instead of ThroughAction::Result, causing the condition to not work properly for ComputePathThroughPoses actions. Fixes #5324 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * Adding slow down at target heading to RPP Controller (#5361) * Adding slow down at target heading to RPP Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * Update test_regulated_pp.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Eexception rethrow in dockRobot method (#5364) Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add global min obstacle height in voxel layer (#5389) * Add min obstacle height in voxel layer Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix linting Signed-off-by: Maurice <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> * [DEX] Enforce 3 digits precision (#5398) Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * [static_layer] limit comparison precision (#5405) * [DEX] limit comparison precision Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * EPSILON 1e-5 Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Smooth path even if goal pose is so much near to the robot (#5423) * Smooth path even if goal pose is so much near to the robot Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Apply suggestions Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Remove unnecessary diff Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> --------- Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Fix KeepoutFilter on the ARM architecture (#5436) Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> * Fix missing dependency (#5460) * bump to 1.3.8 for Jazzy release Aug 19, 2025 Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * load balance CI Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: bhx <1273698633@qq.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: hutao <108395177+coderbaibai@users.noreply.github.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Alberto Tudela <ajtudela@gmail.com> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Cihat Kurtuluş Altıparmak <cihataltiparmak1@gmail.com> Co-authored-by: Sushant Chavan <gitecsvc@gmail.com> Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl>
SteveMacenski
added a commit
that referenced
this pull request
Aug 20, 2025
* enable_groot_monitoring_ false (#5246) Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Add min_distance_to_obstacle parameter to RPP (#4543) * min_distance_to_obstacle Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * suggestion to time base and combine Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * typo Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * use min_approach_linear_velocity Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Parametrizing obstacle layer tf filter tolerance (#5261) Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> * Fix backport compiler warning (#5277) Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Add missing include of algorithm in differential_motion_model.cpp (#5293) Signed-off-by: Silvio Traversaro <silvio@traversaro.it> * Remove unused unistd.h header from route_tool.cpp (#5292) Signed-off-by: Silvio Traversaro <silvio@traversaro.it> * Adding epsilon for voxel_layer precision loss (#5314) * Adding epsilon for voxel_layer precision loss Signed-off-by: bhx <1273698633@qq.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: bhx <1273698633@qq.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * fix: correct ThroughActionResult type alias in would_a_planner_recovery_help_condition (#5326) The ThroughActionResult type alias was incorrectly referencing Action::Result instead of ThroughAction::Result, causing the condition to not work properly for ComputePathThroughPoses actions. Fixes #5324 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * outputting tracker feedback on ComputeAndTrack BT node (#5327) * outputting tracker feedback on BT node Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * initializing outputs Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * outputting last state on success Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * fixed nav2_tree_nodes.xml Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * Update nav2_behavior_tree/include/nav2_behavior_tree/plugins/action/compute_and_track_route_action.hpp Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: alexanderjyuen <103065090+alexanderjyuen@users.noreply.github.com> * consolidated function to set outputs null, only setOutput with active feedback Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * add class to method Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> * linting Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> --------- Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: alexanderjyuen <103065090+alexanderjyuen@users.noreply.github.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * Adding slow down at target heading to RPP Controller (#5361) * Adding slow down at target heading to RPP Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * Update test_regulated_pp.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Include <stdexcept> in docking_exceptions.hpp for exception handling (#5363) Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Eexception rethrow in dockRobot method (#5364) Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add global min obstacle height in voxel layer (#5389) * Add min obstacle height in voxel layer Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix linting Signed-off-by: Maurice <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> * [DEX] Enforce 3 digits precision (#5398) Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * [static_layer] limit comparison precision (#5405) * [DEX] limit comparison precision Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * EPSILON 1e-5 Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * corner case bin check (#5413) Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Add IndexType definition for Nanoflann KDTree in `node_spatial_tree`. (#5420) * fix: Add KDTree type definition to include unsigned int for IndexType Signed-off-by: Ericsii <ericfengx@foxmail.com> * code format Signed-off-by: Ericsii <ericfengx@foxmail.com> --------- Signed-off-by: Ericsii <ericfengx@foxmail.com> * Smooth path even if goal pose is so much near to the robot (#5423) * Smooth path even if goal pose is so much near to the robot Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Apply suggestions Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Remove unnecessary diff Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> --------- Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Fix KeepoutFilter on the ARM architecture (#5436) Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> * Fix missing dependency (#5460) * Support loading multiple behavior tree files as subtrees (#5426) * Support loading multiple behavior tree files as subtrees Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * Fix code style Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * Added default param value Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * Added recursive check to loadBehaviorTree and adapted unit test accordingly Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * Removed nested loadBehaviorTree check in navigators Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * Removed whitespace cpplint Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * Fixed goalReceived Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * Let loadbehaviorTree use its own search_directories var Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * PR fixes-format-lint and test Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * fix pointer Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * Added unit test for BT xml validity Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * CPPLint Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * Check non existent search directory for bt Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * CPPLint Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * Fixed BT tests Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * Fixed BT tests Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> --------- Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> * bump 1.4.0 to 1.4.1 for aug 19 sync Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * Fixing backport error Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * load balance CI Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * Fixing BT Navigator backport merge conflict issue Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: Marco Bassa <marco.bassa@idealworks.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: Silvio Traversaro <silvio@traversaro.it> Signed-off-by: bhx <1273698633@qq.com> Signed-off-by: Alexander Yuen <alex@polymathrobotics.com> Signed-off-by: alexanderjyuen <103065090+alexanderjyuen@users.noreply.github.com> Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> Signed-off-by: Ericsii <ericfengx@foxmail.com> Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> Signed-off-by: Jad El Hajj <jad.elhajj@inmind.ai> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Marco Bassa <101661130+MarcoMatteoBassa@users.noreply.github.com> Co-authored-by: Silvio Traversaro <silvio@traversaro.it> Co-authored-by: hutao <108395177+coderbaibai@users.noreply.github.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: alexanderjyuen <103065090+alexanderjyuen@users.noreply.github.com> Co-authored-by: Alberto Tudela <ajtudela@gmail.com> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: YLFeng <ericfengx@foxmail.com> Co-authored-by: Cihat Kurtuluş Altıparmak <cihataltiparmak1@gmail.com> Co-authored-by: Sushant Chavan <gitecsvc@gmail.com> Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl> Co-authored-by: Jad EL HAJJ <jad.elhajj@inmind.ai>
RBT22
pushed a commit
to EnjoyRobotics/navigation2
that referenced
this pull request
Sep 11, 2025
* Conserve curvature with LIMIT action (ros-navigation#5255) * Conserve curvature with LIMIT action Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix format Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * fix test Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> * Adding epsilon for voxel_layer precision loss (ros-navigation#5314) * Adding epsilon for voxel_layer precision loss Signed-off-by: bhx <1273698633@qq.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Update nav2_costmap_2d/plugins/voxel_layer.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: bhx <1273698633@qq.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Co-authored-by: Steve Macenski <stevenmacenski@gmail.com> * fix: correct ThroughActionResult type alias in would_a_planner_recovery_help_condition (ros-navigation#5326) The ThroughActionResult type alias was incorrectly referencing Action::Result instead of ThroughAction::Result, causing the condition to not work properly for ComputePathThroughPoses actions. Fixes ros-navigation#5324 Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> * Adding slow down at target heading to RPP Controller (ros-navigation#5361) * Adding slow down at target heading to RPP Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * Update test_regulated_pp.cpp Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> --------- Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> * Eexception rethrow in dockRobot method (ros-navigation#5364) Signed-off-by: Alberto Tudela <ajtudela@gmail.com> * Add global min obstacle height in voxel layer (ros-navigation#5389) * Add min obstacle height in voxel layer Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> * Fix linting Signed-off-by: Maurice <mauricepurnawan@gmail.com> --------- Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> * [DEX] Enforce 3 digits precision (ros-navigation#5398) Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * [static_layer] limit comparison precision (ros-navigation#5405) * [DEX] limit comparison precision Signed-off-by: Guillaume Doisy <guillaume@dexory.com> * EPSILON 1e-5 Signed-off-by: Guillaume Doisy <guillaume@dexory.com> --------- Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> * Smooth path even if goal pose is so much near to the robot (ros-navigation#5423) * Smooth path even if goal pose is so much near to the robot Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Apply suggestions Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Remove unnecessary diff Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> --------- Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> * Fix KeepoutFilter on the ARM architecture (ros-navigation#5436) Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> * Fix missing dependency (ros-navigation#5460) * bump to 1.3.8 for Jazzy release Aug 19, 2025 Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> * load balance CI Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> --------- Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com> Signed-off-by: bhx <1273698633@qq.com> Signed-off-by: Steve Macenski <stevenmacenski@gmail.com> Signed-off-by: SteveMacenski <stevenmacenski@gmail.com> Signed-off-by: Alberto Tudela <ajtudela@gmail.com> Signed-off-by: mini-1235 <mauricepurnawan@gmail.com> Signed-off-by: Maurice <mauricepurnawan@gmail.com> Signed-off-by: Guillaume Doisy <guillaume@dexory.com> Signed-off-by: CihatAltiparmak <cihataltiparmak1@gmail.com> Signed-off-by: Sushant Chavan <gitecsvc@gmail.com> Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com> Co-authored-by: hutao <108395177+coderbaibai@users.noreply.github.com> Co-authored-by: claude[bot] <209825114+claude[bot]@users.noreply.github.com> Co-authored-by: Alberto Tudela <ajtudela@gmail.com> Co-authored-by: mini-1235 <mauricepurnawan@gmail.com> Co-authored-by: Guillaume Doisy <doisyg@users.noreply.github.com> Co-authored-by: Guillaume Doisy <guillaume@dexory.com> Co-authored-by: Cihat Kurtuluş Altıparmak <cihataltiparmak1@gmail.com> Co-authored-by: Sushant Chavan <gitecsvc@gmail.com> Co-authored-by: Tim Clephas <tim.clephas@nobleo.nl>
BCKSELFDRIVEWORLD
pushed a commit
to BCKSELFDRIVEWORLD/navigation2
that referenced
this pull request
Sep 23, 2025
Signed-off-by: Sushant Chavan <gitecsvc@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic Info
Description of contribution in a few bullet points
chartype as unsigned as described herecharinstead ofsigned charwhen reading the data fromnav_msgs::msg::OccupancyGridresults in misinterpretation of-1values representing UNKNOWN cells in the filter mask.Description of documentation updates required from your changes
N/A
Description of how this change was tested
Keepout filter was tested on a robot using an ARM-based computer.
Future work that may be required in bullet points
N/A
For Maintainers:
backport-*.