feat: add convex tricycle speed scaling#2149
feat: add convex tricycle speed scaling#2149thedevmystic wants to merge 4 commits intoros-controls:masterfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2149 +/- ##
==========================================
+ Coverage 84.79% 84.83% +0.03%
==========================================
Files 151 151
Lines 14833 14864 +31
Branches 1286 1286
==========================================
+ Hits 12578 12610 +32
+ Misses 1784 1783 -1
Partials 471 471
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
saikishor
left a comment
There was a problem hiding this comment.
Can you add a test verifying the same? I'll need to check math once again.
And if possible add some plots on how it is smoothed out.
christophfroehlich
left a comment
There was a problem hiding this comment.
As we mentioned, this controller is going to be deprecated. Better work on an enhancement in the steering_controller_library, where I already have ported this feature
…2_controllers into tricycle-convex-scaling
|
Well, I didn't knew it was going to be deprecated. But I've already finished the work on this. Well we can complete the TODO and deprecate it, can't we? Because Anyways, this is the data.
Again, @christophfroehlich, I didn't knew about the depreciation, but take a look at it :) |
I haven't deprecated it until #1695 is merged. You can help to leave a review there. As this is kind of a behavior change, I'm unsure if we should merge this into tricycle_controller; or at least don't backport it to the stable branches. |
|
Well I can advise one thing, if That's just my thoughts :) |


Hello, respected maintainers and reviewers!
This is Surya!
This PR addresses:
now, the scale factor is smooth out instead of being janky!