Skip to content

Conversation

@mergify
Copy link
Contributor

@mergify mergify bot commented Jun 18, 2025

Explicitly initialize them, should fix the error reported with #1720 (comment)

I don't know why the tests did not cover this?

Furthermore, I saw that subscriber_is_active_ should be atomic too, as it is used in both threads.


This is an automatic backport of pull request #1749 done by Mergify.

(cherry picked from commit 6920a2a)
@codecov
Copy link

codecov bot commented Jun 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.08%. Comparing base (4b488cb) to head (81c3b1a).
Report is 1 commits behind head on humble.

Additional details and impacted files
@@           Coverage Diff           @@
##           humble    #1765   +/-   ##
=======================================
  Coverage   67.08%   67.08%           
=======================================
  Files         122      122           
  Lines       14506    14506           
  Branches     8964     8954   -10     
=======================================
  Hits         9732     9732           
  Misses       1461     1461           
  Partials     3313     3313           
Flag Coverage Δ
unittests 67.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...jectory_controller/joint_trajectory_controller.hpp 100.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit f778fdf into humble Jun 18, 2025
12 of 14 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/humble/pr-1749 branch June 18, 2025 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants