-
Notifications
You must be signed in to change notification settings - Fork 420
Fix atomic variables in JTC #1749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1749 +/- ##
==========================================
- Coverage 86.30% 86.29% -0.01%
==========================================
Files 123 123
Lines 11940 11941 +1
Branches 994 995 +1
==========================================
Hits 10305 10305
Misses 1333 1333
- Partials 302 303 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
@lqiang2003cn could you please confirm is this fixes the issue you are currently seeing? |
saikishor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
(cherry picked from commit 6920a2a)
(cherry picked from commit 6920a2a)
Explicitly initialize them, should fix the error reported with #1720 (comment)
I don't know why the tests did not cover this?
Furthermore, I saw that
subscriber_is_active_should be atomic too, as it is used in both threads.