Skip to content

Conversation

@christophfroehlich
Copy link
Contributor

Explicitly initialize them, should fix the error reported with #1720 (comment)

I don't know why the tests did not cover this?

Furthermore, I saw that subscriber_is_active_ should be atomic too, as it is used in both threads.

@christophfroehlich christophfroehlich added backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy. labels Jun 9, 2025
@codecov
Copy link

codecov bot commented Jun 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.29%. Comparing base (e00d4cb) to head (22c8aa0).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1749      +/-   ##
==========================================
- Coverage   86.30%   86.29%   -0.01%     
==========================================
  Files         123      123              
  Lines       11940    11941       +1     
  Branches      994      995       +1     
==========================================
  Hits        10305    10305              
  Misses       1333     1333              
- Partials      302      303       +1     
Flag Coverage Δ
unittests 86.29% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...jectory_controller/joint_trajectory_controller.hpp 100.00% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bmagyar
Copy link
Member

bmagyar commented Jun 9, 2025

@lqiang2003cn could you please confirm is this fixes the issue you are currently seeing?

Copy link
Member

@saikishor saikishor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@bmagyar bmagyar merged commit 6920a2a into master Jun 18, 2025
18 of 27 checks passed
@bmagyar bmagyar deleted the fix/jtc branch June 18, 2025 17:46
mergify bot pushed a commit that referenced this pull request Jun 18, 2025
(cherry picked from commit 6920a2a)
mergify bot pushed a commit that referenced this pull request Jun 18, 2025
(cherry picked from commit 6920a2a)
christophfroehlich added a commit that referenced this pull request Jun 18, 2025
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
christophfroehlich added a commit that referenced this pull request Jun 18, 2025
Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-humble Triggers PR backport to ROS 2 humble. backport-jazzy Triggers PR backport to ROS 2 jazzy.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants