Skip to content

Rename ackermann msg to controller state msg type #1662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 27, 2025

Conversation

christophfroehlich
Copy link
Contributor

This is #836 with fixed merge conflicts. Sorry @mbharatheesha that it took us a while ;)

@christophfroehlich christophfroehlich added the backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble. label Apr 26, 2025
Copy link

codecov bot commented Apr 26, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.79%. Comparing base (e2e3df0) to head (32561e2).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1662   +/-   ##
=======================================
  Coverage   84.79%   84.79%           
=======================================
  Files         127      127           
  Lines       12114    12114           
  Branches     1036     1036           
=======================================
  Hits        10272    10272           
  Misses       1503     1503           
  Partials      339      339           
Flag Coverage Δ
unittests 84.79% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...roller/test/test_ackermann_steering_controller.hpp 87.61% <ø> (ø)
...ntroller/test/test_bicycle_steering_controller.hpp 84.70% <ø> (ø)
...llers_library/src/steering_controllers_library.cpp 70.47% <100.00%> (ø)
...library/test/test_steering_controllers_library.hpp 97.22% <ø> (ø)
...troller/test/test_tricycle_steering_controller.hpp 86.31% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 9ff84dc into master Apr 27, 2025
21 of 25 checks passed
@christophfroehlich christophfroehlich deleted the steeringlib/cleanup branch April 27, 2025 07:57
mergify bot pushed a commit that referenced this pull request Apr 27, 2025
Co-authored-by: Mukunda Bharatheesha <mukunda.bharatheesha@nobleo.nl>
(cherry picked from commit 9ff84dc)

# Conflicts:
#	steering_controllers_library/include/steering_controllers_library/steering_controllers_library.hpp
christophfroehlich added a commit that referenced this pull request Apr 27, 2025
Co-authored-by: Mukunda Bharatheesha <mukunda.bharatheesha@nobleo.nl>
@mbharatheesha
Copy link
Contributor

This is #836 with fixed merge conflicts. Sorry @mbharatheesha that it took us a while ;)

@christophfroehlich Thank you and also sorry from my side I couldn't follow up on this last week. Glad it's merged!

christophfroehlich pushed a commit that referenced this pull request Apr 27, 2025
…1663)

Co-authored-by: Mukunda Bharatheesha <mukunda.bharatheesha@nobleo.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-humble This label should be used by maintainers only! Label triggers PR backport to ROS2 humble.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants