-
Notifications
You must be signed in to change notification settings - Fork 378
Improve steering controller tests #1630
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Improve steering controller tests #1630
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1630 +/- ##
==========================================
+ Coverage 86.29% 86.37% +0.08%
==========================================
Files 123 124 +1
Lines 11941 11982 +41
Branches 995 1012 +17
==========================================
+ Hits 10305 10350 +45
+ Misses 1333 1329 -4
Partials 303 303
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Thanks for your contribution, I try to come back with a review soon. Could you please review #1166 in the meantime? This should get merged soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had a look now, but I don't understand the approach you have used here. For me it seems that in the end, we have the exact same tests like before, but added 650 lines of code? What is the purpose of using parameterized tests, but have a condition in every test to skip if it does not match the single test which was here before? Please explain, maybe I just don't see it.
Closes #930