Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segmentation fault if transmission plugin is not specified #543

Open
v-lopez opened this issue Sep 27, 2021 · 0 comments
Open

Segmentation fault if transmission plugin is not specified #543

v-lopez opened this issue Sep 27, 2021 · 0 comments

Comments

@v-lopez
Copy link
Contributor

v-lopez commented Sep 27, 2021

Describe the bug
Some time in the past, a keyword in the transmission description was changed from type to plugin, we somehow missed that.
If you attempt to load a transmission with the old format, it segfaults.
Probably caused by this and the next line:
https://github.com/ros-controls/ros2_control/blob/0.8.0/hardware_interface/src/component_parser.cpp#L391

To Reproduce
Steps to reproduce the behavior:
Remove or rename the plugin attribute on a transmission.
Load the description.

Expected behavior
It thows an exception indicating the error.

Screenshots
If applicable, add screenshots to help explain your problem.

Environment (please complete the following information):

  • OS: Ubuntu Focal
  • Version Foxy
@v-lopez v-lopez added the bug label Sep 27, 2021
pac48 pushed a commit to pac48/ros2_control that referenced this issue Jan 26, 2024
…-controls#543)

* Add pid gain structure to documentation

* Remove trailing whitespace

* Remove trailing colons

(cherry picked from commit e0a373ab09cdf8c268bc3c8d14c4a3c0db59b724)

Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants