[IMT] Add TThreadedObject::GetAtSlotRaw #934
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compared to `GetAtSlotUnchecked`, `GetAtSlotRaw` trades some more safety for some more performance: not only it avoids checking for slot initialization (as `GetAtSlotUnchecked` does) but it also avoids construction of a `shared_ptr`.
|
Starting build on |
1 similar comment
|
Starting build on |
Member
|
Hi @bluehood , this is exactly the feature we discussed a while ago. To make the PR even more complete, I could suggest a gtest for TThreadedObject, which would also increase our coverage given that it is a template. |
dpiparo
approved these changes
Sep 5, 2017
This was referenced Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compared to
GetAtSlotUnchecked,GetAtSlotRawtrades some moresafety for some more performance: not only it avoids checking for
slot initialization (as
GetAtSlotUncheckeddoes) but it also avoids(copy-)construction of a
shared_ptr.I can add a test, just tell me where :)