[hist] TH1::GetCumulative: fix error setting #11948
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
2 tasks
lmoneta
approved these changes
Dec 21, 2022
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
Thank you for this fix. I agree this was a bug, great you have found it.
Just a small comment for avoid using virtual functions (TArray::SetAt) for better efficiency
hist/hist/src/TH1.cxx
Outdated
| if (fSumw2.fN) { | ||
| esum += GetBinErrorSqUnchecked(bin); | ||
| fSumw2.fArray[bin] = esum; | ||
| hintegrated->GetSumw2()->SetAt(esum, bin); |
Member
There was a problem hiding this comment.
It is maybe shorter and more efficient to write:
hintegrated->fSumw2.fArray[bin] = esum;
Contributor
Author
There was a problem hiding this comment.
Cool! But why are these protective attributes of a non-self TH1 instance accessible here?
Contributor
Author
There was a problem hiding this comment.
It is maybe shorter and more efficient to write:
hintegrated->fSumw2.fArray[bin] = esum;
Updated and tested.
Assign the cumulative error to the newly generated histogram instead of the original one.
ShamrockLee
force-pushed
the
hist-cumulative-error
branch
from
f2e7c81 to
24eceeb
Compare
lmoneta
approved these changes
Dec 23, 2022
Member
|
@phsft-bot build! |
|
Starting build on |
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Errors:
Warnings:
And 130 more Failing tests:
And 7 more |
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Warnings:
And 60 more Failing tests:
|
|
Build failed on ROOT-ubuntu2004/python3. Warnings:
And 54 more Failing tests:
|
|
Build failed on mac11/cxx14. Errors:
Warnings:
And 54 more Failing tests:
And 7 more |
|
Build failed on mac12/noimt. Warnings:
And 53 more Failing tests:
|
Contributor
Author
|
Is there something I need to fix? |
lmoneta
approved these changes
Jan 5, 2023
Member
lmoneta
left a comment
lmoneta
left a comment
There was a problem hiding this comment.
LGTM!
Thank you for this fix!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Changes or fixes:
This PR fixes the
TH1::GetCumulative()method by assigning the cumulative error to the newly generated histogram instead of the original one.Checklist:
This PR fixes #11947