[RF][HS3] Add importers and exporters for RooRealSumFunc and RooHistPdf #10210
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cburgard
requested review from
guitargeek,
hageboeck and
lmoneta
as code owners
|
Can one of the admins verify this patch? |
cburgard
force-pushed
the
hs3-extensions
branch
from
157c44d to
98ba13f
Compare
guitargeek
reviewed
Mar 23, 2022
| { | ||
| const RooRealSumFunc *pdf = static_cast<const RooRealSumFunc *>(func); | ||
| elem["type"] << key(); | ||
| auto &samples = elem["samples"]; |
Contributor
There was a problem hiding this comment.
Why is this called samples? This is specific to HistFactory, but in general the functions can also represent things that are not "samples". Can it just be called "functions" without any compatibility issues?
Contributor
Author
There was a problem hiding this comment.
I opted for "samples" rather than "functions" because the structure of the sumpdf with "functions" and "coefficients" is clearly intended to work that way - if you're just adding random stuff, you could also use RooAddition or RooAddPdf
guitargeek
reviewed
Mar 23, 2022
| bool importPdf(RooJSONFactoryWSTool *tool, const JSONNode &p) const override | ||
| { | ||
| std::string name(RooJSONFactoryWSTool::name(p)); | ||
| if (!p.has_child("data")) { |
Contributor
There was a problem hiding this comment.
I only see a data child here. But to fully specify a RooHistPdf, don't you also need the bin boundaries? Where are they stored?
Contributor
Author
There was a problem hiding this comment.
The bin boundaries are stored in the observables.
Contributor
|
Hi Carsten, thanks for the PR! LGTM for the code, I only have a few comments about what is stored in the JSON. |
cburgard
force-pushed
the
hs3-extensions
branch
from
4066314 to
3740d21
Compare
It's better to have the tests in C++, because this is easier to debug in case of failures.
guitargeek
force-pushed
the
hs3-extensions
branch
from
136cd90 to
6bbb1e3
Compare
guitargeek
changed the title
52 tasks
guitargeek
force-pushed
the
hs3-extensions
branch
2 times, most recently
from
ea83b99 to
4a0bdf9
Compare
Follow up to 98f6c2f, where `RooStats::FeldmanCousins::SetData()` got removed because it was deprecated. However, it was necessary to keep it because the base class requires it to be implemented.
guitargeek
force-pushed
the
hs3-extensions
branch
from
4a0bdf9 to
5697b79
Compare
|
Starting build on |
|
Build failed on mac12/noimt. Warnings:
And 53 more Failing tests:
|
|
Build failed on ROOT-performance-centos8-multicore/cxx17. Warnings:
And 130 more Failing tests:
|
|
Build failed on ROOT-ubuntu18.04/nortcxxmod. Warnings:
And 60 more Failing tests:
|
|
Build failed on ROOT-ubuntu2004/python3. Warnings:
And 54 more Failing tests:
|
guitargeek
approved these changes
Dec 27, 2022
|
Build failed on mac11/cxx14. Warnings:
And 54 more Failing tests:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request:
Adds importers and exporters for RooHistPdf and RooRealSumFunc
Checklist:
This PR fixes #