-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cxxmodules] Preload tmva tree player graf #1365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cxxmodules] Preload tmva tree player graf #1365
Conversation
|
Starting build on |
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 3 more Warnings:
And 7 more Failing tests:
And 222 more |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 3 more Warnings:
And 7 more Failing tests:
And 208 more |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 3 more Warnings:
And 7 more Failing tests:
And 208 more |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
Warnings:
And 7 more |
ROOT can't autoparse classes inside namespaces with the rootmap system (as the loading callbacks don't correctly land where they are supposed to land with our injected namespaces). As this turns out to be a feature of some kind, let's preload TMVA/TreePlayer to fix all failing tests that are related to this feature/bug with modules enabled.
b665a26 to
2616528
Compare
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 3 more Warnings:
And 7 more Failing tests:
And 77 more |
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Dctest_test_exclude_none=on |
|
Starting build on |
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Droofit=Off -Dctest_test_exclude_none=on |
|
Starting build on |
|
Build failed on slc6/gcc62. |
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Droofit=Off -Dctest_test_exclude_none=on |
|
Starting build on |
|
Build failed on slc6/gcc62. |
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Droofit=Off -Dctest_test_exclude_none=on |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 1 more Warnings:
Failing tests:
And 79 more |
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Droofit=Off -Dctest_test_exclude_none=on |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 1 more Warnings:
Failing tests:
And 32 more |
|
@phsft-bot build just on slc6/gcc62 with flags -Druntime_cxxmodules=On -Droofit=Off -Dctest_test_exclude_none=on |
|
Starting build on |
|
Build failed on slc6/gcc62. Errors:
And 5 more Failing tests:
And 33 more |
|
I think we can close this as well, for the same reason as #1697 . We don't have to preload these for specific modules |
|
I agree this one is superseded by #1697. |
Rebase PR #1355.