Remove redundant null pointer check #249
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Indeed we only use github for merge request. Issues are being tracked in JIRA at: https://sft.its.cern.ch/jira/issues/?jql=project%20%3D%20ROOT To create an issue: https://sft.its.cern.ch/jira/secure/CreateIssue.jspa?pid=10010&issuetype=1 |
Member
|
merged. Thanks. |
Author
|
@pcanal any advice on how to report about dozen of small errors ~1 line of code each? 1 issue for all or 1 issue per error? |
Member
|
I would recommend one merge request with one commit per category of issues. |
Author
|
I was asking about reporting issues I don't know how to fix... |
Member
|
Then one JIRA issue/ticket per category of problems or 1 issue per error. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See SafeDelete definition
It seems that new static analyzer exhumes lots of ancient legacy. Do I (we) need to give attention to such cases?
And it seems that there is no "Issues" tab in this repository. I have got some suspicious places and I'm not sure how to fix them.